GithubHelp home page GithubHelp logo

Comments (1)

leoschwarz avatar leoschwarz commented on June 3, 2024

My main reason for the linked PR was that I think at that time there was no event updating endpoint, but since it's possible I don't see a stringent need for it anymore. Also maybe it should be named update if it were to be added.

If one out of many replaces in /insert fails we have no idea what actually happened, we need to do fetch the events after to be certain which should be unnecessary

One could change

Ok(events) => Ok(Json(events)),
Err(e) => match e {
DatastoreError::NoSuchBucket => Err(Status::NotFound),
e => {
warn!("Failed to create event(s): {:?}", e);
Err(Status::InternalServerError)
}
},

to return per event success/failure information in the response body (and set success in the header if everything succeeded, failure otherwise). For example, you could add an additional "success": field to events inserted, the details of this would be something to think about if this approach is chosen.

So I think it's mainly an API design choice whether to have this endpoint or not (simpler vs lower number of endpoints).

from aw-server-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.