HTTP CONNECT requests fail when LittleProxy is chained to another proxy about littleproxy

[adamfisk]

Thanks Emil -- good catch. Does that fix work fully for you? It seems like we'd also need to strip our the HttpResponseDecoder once the CONNECT tunnel is established, as otherwise I think LittleProxy will try to read all the encrypted data coming back as HTTP responses. Has that not caused a problem for you?

[EmilGoicovici]

No, I had no issues with my fix. I don't have time right now to debug these classes at runtime, but as I can see from the source-code, the ChannelPipeline instance used between LittleProxy <-> upstream chain proxy does not have any HttpResponseDecoder handler on it (as you can see, the handlers for this pipeline are added inside HttpRequestHandler.newChannelFuture() method; there is no decoder appended there, just the HttpConnectRelayingHandler instance ). I append one encoder on my fix source-code and remove it when the write operation completes in order to be able to forward the HTTP request to the upstream chain proxy. After that point, LittleProxy acts just as a relay for that connection.

[adamfisk]

OK -- I had previously committed a half-baked implementation of this fix by mistake, but I just committed the real thing.

I'm closing this out for now. Thanks again.