HttpServerPipelineFactory doesn't enforce an idle handler, though the client (DefaultRelayPipelineFactory) does about littleproxy

[adamfisk]

Thanks @theotherian. Does the commit above do what you want?

[theotherian]

Yep, looks functionally the same as what I did. Should work just fine.

That said, if I may make a suggestion...

One of the other changes I made was changing the state of the HttpRequestHandler to maintain the HttpRequest instances regardless of whether or not useJmx was set to true. I also made a subclass of IdleAwareHandler that accepts an HttpRequestHandler in its constructor. This allowed me to find the requests that weren't fulfilled and log information that would tell me what resources were running slow. I'm not sure if this is a broad enough use case to justify the work, but it's certainly handy for debugging purposes while testing.

[myleshorton]

Sounds great. Any interest in putting in a pull request to get those changes in?

[theotherian]

Sorry it's taken more forever to get back to you on this.

Yes, I want to put a pull request in. :)

Right now I'm working on trying to get the right patch file put together. My IDE made a bunch of whitespace changes that are totally unnecessary, so I'm working on creating a patch that just contains the relevant changes.

[adamfisk]

No worries at all -- I actually added idle state handling to HttpServerPipelineFactory on master. Can you take a look to make sure it's what you imagined? I have a ticket open to make it more configurable too -- currently just hard-coded to 70 seconds with both reads and writes being idle.

[theotherian]

I reviewed it when you first checked it in, and again after forking your code for the pull request. As far as I can tell, everything looks good.

Configurability would be nice but the defaults are very reasonable. I would say it would also make sense to have the timeouts configurable on proxy to web connections as well, and also add some validation that the threshold for those is never greater than browser to proxy connections, lest you end up in the same situation that caused this ticket to be created :)

[theotherian]

Closing issue since the patch has been added :)