getMaxResponseSize() in DefaultHttpFilter should return a larger value about littleproxy

[adamfisk]

This value really depends on the needs of your application. The underlying problem is really holding large responses in memory. The chunking allows LittleProxy/Netty to only hold chunks in memory and then pass them back to the client/browser one by one. The problem is that chunked responses are tricky to filter, so you'll often want the whole response in order to determine whether or not to filter it. With big files/responses though, it can just start to consume a lot of memory. If that's not a problem in your case, though, it's fine to just increase that size in your filter to whatever value you think is an appropriate limit. I'll go ahead and bump up the default to 1MB though, as I agree 200K is pretty small.

Would that solve the problem you brought up in https://groups.google.com/d/topic/littleproxy/maorfyDonSk/discussion or is there still additional work to be done?

[nasis]

Yes increasing this size solves my problem. Thanks.

On Tue, Sep 4, 2012 at 9:00 PM, adamfisk [email protected] wrote:

This value really depends on the needs of your application. The underlying
problem is really holding large responses in memory. The chunking allows
LittleProxy/Netty to only hold chunks in memory and then pass them back to
the client/browser one by one. The problem is that chunked responses are
tricky to filter, so you'll often want the whole response in order to
determine whether or not to filter it. With big files/responses though, it
can just start to consume a lot of memory. If that's not a problem in your
case, though, it's fine to just increase that size in your filter to
whatever value you think is an appropriate limit. I'll go ahead and bump up
the default to 1MB though, as I agree 200K is pretty small.

Would that solve the problem you brought up in
https://groups.google.com/d/topic/littleproxy/maorfyDonSk/discussion or
is there still additional work to be done?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/41#issuecomment-8272642.