A small regular expression problem about surplus

[ismail-codar]

Is the regexp usage unnecessary here. We want to exact match on this line and can be as var svg = svg || SvgOnlyTags.indexOf(tag)!= -1

[adamhaile]

It's a single char typo. In SvgOnlyTagRx, the $ anchoring the end of the match is inside the parens when it should be outside. So it only anchors the last tag, not all of them. I'm away camping with the family but will fix it as soon as I'm back.

[ismail-codar]

No hurry! sometimes need to raise head from the computer. I can go on with these kind of things I've done in my own repository. The following code can provide convenience for simulating the problem.

var SvgOnlyTags =  [
    "text",
    "textPath"
],
SvgOnlyTagRx = new RegExp("^(" + SvgOnlyTags.join("|") + "$)")
console.log(SvgOnlyTagRx.test("textField")) // true!!!!!!

[adamhaile]

Pushed fix.

The reason for the RX over an array search is both performance and expressive power. I don't care nearly as much about performance in the preprocessor as I do in the runtime and generated code, but using an RX here is O(tag length) vs an array search which is O(tag length * # of SVG tags). V8's regex implementation is pretty darn fast.

[ismail-codar]

Good