GithubHelp home page GithubHelp logo

Comments (6)

adams85 avatar adams85 commented on August 20, 2024 1

It's just a publishing profile, making it easier to handle locally. It's not intended for general binary tool distribution.

Ah, ok, I see.

It wasn't. It was a bug in the resx extractor, not properly handling embedded newlines in the value.
The fix will also be included.

Great news, thanks!

Would you like me to do the .NET 8 upgrade as well? (Just the POTools...)

Hmm, I think it wouldn't make much sense to upgrade the target framework to .NET 8 now, for the following reasons:

  • The whole project is on .NET 6 currently.
  • .NET 6 is still supported.
  • POTools doesn't need post-.NET 6 features.

However, probably we should add <RollForward>Major</RollForward> to the csproj, so it can be run on .NET 8 without having the .NET 6 runtime installed.

from aspnetskeleton2.

adams85 avatar adams85 commented on August 20, 2024

Hi @xecrets,

First of all, I'm glad that you find the project useful!

I'd say it's temporary inactive as other projects are in my focus at the moment. However, I have plans for further improvements (upgrade to .NET 8, write some documentation, add a Blazor frontend, maybe a Vue one, to name a few).

But, of course, I welcome any contributions outside of these areas as well.

May I ask what improvements to POTools do you have in mind?

from aspnetskeleton2.

xecrets avatar xecrets commented on August 20, 2024

Hi, thanks for quick response! I totally get the "temporary inactive" status... My primary interest right now is to do some minor improvements to the resx extractor, specifically add support for translator comments and a publishing profile to enable creation of a single file executable for easier use outside of the web template context. I am planning to use it for localization of an Avalonia UI-based app. I might also want to fix what I think is a bug in the underlying Karambolo.PO library, as it's currently blowing up for me with a 'An item with the same key has already been added' argument exception in merge mode ;-) .

I'd be happy to upgrade the POTools to .NET 8 as well I guess. The ASP.NET solution is a little out of scope for me, but POTools stands on it's own as far as I can tell.

from aspnetskeleton2.

adams85 avatar adams85 commented on August 20, 2024

My primary interest right now is to do some minor improvements to the resx extractor, specifically add support for translator comments

Sounds awesome!

and a publishing profile to enable creation of a single file executable for easier use outside of the web template context.

Regarding publishing, please be aware that I have no plans to distribute the tool in a binary form. There has been a discussion about this: #1 (comment)

Currently, the recommended way to include POTools is to copy its source code into your project and to modify it according to the needs of your application.

So please send only those changes upstream that are not specific to your application (general improvements, bug fixes, etc.)

I might also want to fix what I think is a bug in the underlying Karambolo.PO library, as it's currently blowing up for me with a 'An item with the same key has already been added' argument exception in merge mode ;-)

If it turns out to be an actual bug, I'd really appreciate if you opened an issue or PR about it.

I'd be surprised though if it were a bug in Karambolo.PO. That library is pretty battle-tested now. If there's an issue, then it's more likely in POTools.

Anyway, here are some hints where you can start investigation:

from aspnetskeleton2.

xecrets avatar xecrets commented on August 20, 2024

and a publishing profile to enable creation of a single file executable for easier use outside of the web template context.

Regarding publishing, please be aware that I have no plans to distribute the tool in a binary form. There has been a discussion about this: #1 (comment)

It's just a publishing profile, making it easier to handle locally. It's not intended for general binary tool distribution.

So please send only those changes upstream that are not specific to your application (general improvements, bug fixes, etc.)

Of course.

I might also want to fix what I think is a bug in the underlying Karambolo.PO library, as it's currently blowing up for me with a 'An item with the same key has already been added' argument exception in merge mode ;-)

If it turns out to be an actual bug, I'd really appreciate if you opened an issue or PR about it.

It wasn't. It was a bug in the resx extractor, not properly handling embedded newlines in the value.
The fix will also be included.

Would you like me to do the .NET 8 upgrade as well? (Just the POTools...)

You can sneak a peek here: master...xecrets:aspnetskeleton2:feature/resxandpublish .

from aspnetskeleton2.

adams85 avatar adams85 commented on August 20, 2024

Closing as resolved by #6

from aspnetskeleton2.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.