GithubHelp home page GithubHelp logo

Undefined in requirejs about log HOT 6 CLOSED

adamschwartz avatar adamschwartz commented on April 28, 2024
Undefined in requirejs

from log.

Comments (6)

 avatar commented on April 28, 2024

@wenerme I'm having the same problem, were you able to figure this out?

from log.

 avatar commented on April 28, 2024

I figured it out. The AMD definition is incorrect at log.coffee:110:

  define exportedLog

should be

  define -> exportedLog

@adamschwartz I can make a pull request with this fix if desired, or you can do it since it's so small.

from log.

adamschwartz avatar adamschwartz commented on April 28, 2024

Thanks @wenerme & @dav- for reporting this.

Interestingly enough, it looks like this was fixed with #32 in the JS, but not the original Coffeescript. Are we sure that this is now correct?

Let’s also loop in @alessioalex, the original author of the AMD stuff (#30), and @rodneyrehm, the author of the JS fix in (#32), for some extra eyes.

from log.

 avatar commented on April 28, 2024

@adamschwartz I found that just before you commented. It's interesting that it's fixed in the JS, because the package I got from Bower seemed to have the unfixed JS.

from log.

rodneyrehm avatar rodneyrehm commented on April 28, 2024

#32 only fixed the compile target, not the compiled source. so any time someone compiled the CoffeeScript, the error would reappear. I have no Idea how I only fixed the JS, but not the CS. Shame on me :/

from log.

adamschwartz avatar adamschwartz commented on April 28, 2024

Np @rodneyrehm :)

Alllright. 86a79c7 and fadf243 should bring us home.

Thx all!

from log.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.