Error while loading [stackline needs to be global variable in init.lua] about stackline

[acmcelwee]

@Liquidmantis I was in the same position as you. I'm guessing this TODO is relevant to us:

stackline/stackline/stackline.lua

Lines 81 to 86 in 71dc951

	-- TODO: Add instructions to README.md to call stackline:start(userPrefs) from init.lua, and remove this.
	hs.timer.doUntil(function() -- {{{
	return stackline.manager
	end, function()
	stackline.start()
	end, 0.1) -- }}}

For myself, I fixed it by updating my init.lua to include this:

hs.timer.waitUntil(function()
  return stackline.manager
end, function() 
  stackline.manager:toggleIcons()
end, 0.1)

[CyrilPeponnet]

It fixed it for me indeed.

[Liquidmantis]

Ah, I found my problem by looking more closely at the stack trace. I had stackline.manager:toggleIcons() in my init.lua and commenting that out resolves the issue. I'm still digging around to figure out why that broke with the recent changes, though.

[Edit] maybe it's a race condition? Once things are loaded I can run that command in the Hammerspoon console and it toggles the icons as expected.

[Liquidmantis]

I just updated Stackline and get similar wfilter errors. I too have Yabai HEAD installed, but with the scripting additions, and had Stackline working until I updated just now.

[Liquidmantis]

Looks like this is from the hs.filter changes in 71dc951. If I checkout 4791ca1, which is where I think I was prior to updating, things work again. Checking out 71dc951 introduces the errors, though.

[AdamWagner]

Hi @Liquidmantis @CyrilPeponnet

I'm sorry.
I'm new at this, and don't know how to "release" breaking updates. Maybe a pinned issue describing the changes?

Please update your init.lua file:

FROM:
local stackline = require "stackline.stackline.core"
or
local stackline = require "stackline.stackline.stackline"

TO:

stackline = require "stackline.stackline.stackline"

[CyrilPeponnet]

No worries, it works :p thanks for that.

[Liquidmantis]

@AdamWagner I had already switched to the global variable, unfortunately.
https://github.com/Liquidmantis/dotfiles/blob/master/hammerspoon/init.lua

@CyrilPeponnet this fixed it for you then?

[AdamWagner]

You nailed it @acmcelwee. Thanks for helping out!

It sounds like completing that TODO would be a good thing to focus on next. #33