Comments (3)
Hi Jan. Sorry for the delay in responding -- I only just got back from PTO today.
Thanks very much for looking into this code and more so for submitting a PR to improve it. I am afraid I have not been actively maintaining it due to lack of available time. Are you hoping to continue adding to the current code or is this just a one off patch? If you are willing and able to help with maintenance then I'm very happy to collaborate as far as time allows. That doesn't really require a master release to exist in my repo but I would be happy to use it as a target for other PRs if you would prefer.
But first I think it would be obviously best to merge dbg.py, dbg7.py and dbg8.py into a runtime detection
Yes, I am happy with this idea -- the parts of the JVM this code depends on have changed between releases but not greatly. So, a single version that uses runtime detection seems like a workable idea. I also agree that the jdk7 code is best left unmerged. jdk7u support is not enough of a priority for it to be worth complicating the code in the merged version and also the existing code is unlikely to need an maintenance so can just stay as is as a special case. Obviously jdk8u and jdk11u support is the current priority. The code in dbg.py was developed on jdk9 but I believe it still works fine for jdk11u. I am happy to pull your PR so we have one version for those two releases
It would be nice also to support later releases. I am not sure the current code works correctly on jdk17u -- I cannot recall specific changes that might lead to breakage but I have an idea that there have been some CDS-related changes that could be a problem. It would be good to get it to work on that release too as jdk17u deployments are steadily becoming more common. I guess it would also be good to have a version that worked on the jdk head release. Anyway, that's for a later update.
n.b. I appreciate that you have commented all the places where jdk release-specific behaviour is implemented. That approach can probably just be extended to deal with changes needed for later releases -- or alternatively a big enough change might imply the need for release-specific variants of some of the python functions/methods. Also an issue for a later update.
from unwinder.
I may implement some more archs for the unwinding. But sure it is only a very minor project for me in my job. Yes, I would prefer to keep the repository in your github so far.
I was asking in our company and there isn't much interest in JDK <=7 for this unwinding project so I am keeping dbg7.py
intact.
Thanks for reminding me to test recent versions of JDK, I have tested now jdk17u
and a smoke test does work for me.
I think my questions of this issue have been answered so I am closing it, thanks.
from unwinder.
Thanks for the contributions and also for checking jdk17u.
from unwinder.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unwinder.