adlawson / search-algorithms Goto Github PK

I tried your bfs.lua code (it is high on google search for "bfs lua"). however, I'm not sure if it is entirely correct. While your test gives the expected result when the starting node is 1, just using a random other starting node doesn't give me the expected results:
Replacing 1 by 7 in your test case, I get this output
7, 4, 11, 12, 7, 8, 7, 7, 11, 12, 11, 12, 11, 12
Nodes missing (anything smaller than 7 it seems), many being duplicated; pretty sure this is not correct.

BFS fails on line 31:

Bug Bug ..!!** (ArgumentError) the Access calls for keywords expect the key to be an atom, got: 1 (elixir) lib/access.ex:329: Access.get/3 lib/bsf.ex:39: anonymous fn/3 in Bfs.frontier_adj/2 (elixir) lib/enum.ex:1826: Enum."-reduce/3-lists^foldl/2-0-"/3 lib/bsf.ex:31: Bfs.visit_frontier/3

And DFS Fails on line 22:

Bug Bug ..!!** (ArgumentError) the Access calls for keywords expect the key to be an atom, got: 1 (elixir) lib/access.ex:329: Access.get/3 lib/dfs.ex:22: Dfs.visit/3