GithubHelp home page GithubHelp logo

Comments (5)

vbhayden avatar vbhayden commented on June 14, 2024

They aren't equivalent, but it looks to only be a difference of how the statement IDs are submitted. The singular sendStatement() checks for an ID and supplies one if necessary, whereas sendStatements() doesn't make that check and sends the array as-is.

What status code is the LRS sending back?

from xapiwrapper.

brian-learningpool avatar brian-learningpool commented on June 14, 2024

Learning Locker v1 sends back a 500 status with Attempt to assign property of non-object.

I guess the question is, should they be equivalent?

from xapiwrapper.

vbhayden avatar vbhayden commented on June 14, 2024

I'm inclined to think that they should be equivalent yeah. You'd naturally assume that if a function already exists to do something once, then an analogous version for an iterable of the same object is just calling that singular one somewhere.

The problem with making it an equivalent is that the function would no longer be capable of returning the response for the request that sent the statement array.

By the Spec, an LRS should be capable of processing arrays of statements and the example page useWrapper.html seems to do this fine. Are you able to describe the kinds of statements that are being rejected by sendStatements() and accepted by iterated sendStatement() calls?

from xapiwrapper.

brian-learningpool avatar brian-learningpool commented on June 14, 2024

Hi @vbhayden, apologies for the delay.

The kinds of statements being rejected by the LRS when calling sendStatements() are the launched and initialized statements. When called in a sendStatement() loop they work fine.

Again, this was only a problem when used with the ADL launch mechanism.

from xapiwrapper.

vbhayden avatar vbhayden commented on June 14, 2024

Sorry for the late response, especially with such a silly question, but does sendStatements() work when the launched / initialized verbs are excluded?

from xapiwrapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.