Comments (3)
aiojbot
commented on June 19, 2024
JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-987
from aio-lib-files.
purplecabbage
commented on June 19, 2024
isn't it easier just to support it? I would just prevent it from throwing an error and move on
from aio-lib-files.
moritzraho
commented on June 19, 2024
@purplecabbage yes, it's about generating the presign URL against the public container instead of the private one when the file starts with 'public/' prefix
This needs fixing in two places:
- TVM case: fix here - https://github.com/adobe/aio-tvm/blob/master/lib/impl/AzurePresignTvm.js#L51
- BYO case: fix here - https://github.com/adobe/aio-lib-files/blob/master/lib/impl/AzureBlobFiles.js#L551
from aio-lib-files.
Related Issues (20)
- update node engine support to 12 or greater HOT 2
- test failures with new [email protected] dependency HOT 1
- codecov in Github Action needs to be updated HOT 1
- Typescript error
- Support private-only container for BYO credentials HOT 1
- document what `public` means for files HOT 1
- document expiryInSeconds
- delete should accept a list of files to delete HOT 2
- allow some calls to use wildcard glob matching to search HOT 2
- append mode HOT 5
- List should support pagination with a documented default and max limit HOT 1
- azure v12 should have fixed getAccessPolicy, replace custom code with azure sdk call HOT 2
- presignUrl with write permissions and BYO credentials fail on PUT Blob HOT 1
- Introduce a `move` function HOT 10
- Generated presigned URLs do not work in the browser HOT 4
- presignedUrl file path must already exist HOT 1
- Azure blob store on-the-fly gzip compression HOT 3
- Allow all origins for presigned URL HOT 10
- CDN domain should be returned by the TVM HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aio-lib-files.