Ensure that the selected default Gateway is the actual external router about waifupnp

[adolfintel]

An unusual situation for sure, but not unheard of. As far as I know your fix should work, wanna send a PR?

[oreillymj]

Tried opening a PR but didn't want to push to master
How does this look?

@Override
        public void run() {
            boolean foundgw=false;
            Gateway gw=null;
            try {
                byte[] req = this.req.getBytes();
                DatagramSocket s = new DatagramSocket(new InetSocketAddress(ip, 0));
                s.send(new DatagramPacket(req, req.length, new InetSocketAddress("239.255.255.250", 1900)));
                s.setSoTimeout(3000);
                for (;;) {
                    try {
                        DatagramPacket recv = new DatagramPacket(new byte[1536], 1536);
                        s.receive(recv);
                        //System.out.println("Gateway address " + recv.getAddress().getHostAddress());
                        gw = new Gateway(recv.getData(), ip, recv.getAddress());

                        String extIp= gw.getExternalIP();
                        if( (extIp!=null) && (!extIp.equalsIgnoreCase("0.0.0.0")) ){ //Exclude gateways without an external IP
                            gatewayFound(gw);
                            foundgw=true;
                        }
                    } catch (SocketTimeoutException t) {
                        break;
                    } catch (Throwable t) {
                    }
                }
            } catch (Throwable t) {
            }
            if( (!foundgw) && (gw!=null)){ //Pick the last GW if none have an external IP - internet not up yet??
                gatewayFound(gw);
            }
        }

[adolfintel]

Sorry for the late reply
Your code should work. Pushing to master is the right thing to do, pushing to your master will update the PR, it won't go straight to my master.

[oreillymj]

Hi,
Tried to create a PR from InteliJ, but it says the oreillymj @ gmail .com doesn't have the required repo permissions.

[adolfintel]

Here's how it works:

• Fork this project, you'll see a copy of it in your repos on github
• Make the changes on your fork
• Push to your fork
• On the github page for your fork, you'll see a Pull request button

[oreillymj]

Thanks for your patience, hopefully what I've done is correct.

[adolfintel]

Yes, you did it right. You don't have to call the PR "master" though, you should give a quick description of what your PR does.

[oreillymj]

Thanks, yes the Intelij dialog picked that as the default PR name. It wasn't obvious at the time what the field was.