GithubHelp home page GithubHelp logo

Comments (6)

blimmer avatar blimmer commented on May 22, 2024

If it's a valid character in emails, I think we should allow it. I, personally, use this all the time to see who sold my email (e.g. spam to [email protected])

If people want to prevent the +, they should make a custom validator IMO.

from ember-cp-validations.

offirgolan avatar offirgolan commented on May 22, 2024

I agree. Ill add a more extensive email regex.

from ember-cp-validations.

stefanpenner avatar stefanpenner commented on May 22, 2024

worth a read: http://davidcel.is/posts/stop-validating-email-addresses-with-regex/

from ember-cp-validations.

blimmer avatar blimmer commented on May 22, 2024

I get the article's point, but when user registration is a key business metric, you really want to make sure that something stupid (like fat-fingering an email address) doesn't cause you to lose a registration. New users are valuable.

from ember-cp-validations.

ronco avatar ronco commented on May 22, 2024

I think trying to get a perfect email regex would be a fool's errand.

However there is value in having a 99% solution to help out with fat-fingering and such. Consumers of this library can always override with their own regex if they want to be vastly more permissive. I think the current implementation is already covering 98%, it's just us techie types that really make use of the '+' in addresses.

from ember-cp-validations.

stefanpenner avatar stefanpenner commented on May 22, 2024

I think what the article really suggests is: be aware of the short-comings, and choose appropriately.

The title really is more click bait

from ember-cp-validations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.