GithubHelp home page GithubHelp logo

Comments (8)

tellison avatar tellison commented on July 3, 2024

Screenshot 2022-05-06 20 57 41

from adoptium.net.

tellison avatar tellison commented on July 3, 2024

Screenshot 2022-05-06 21 00 06

from adoptium.net.

tellison avatar tellison commented on July 3, 2024

Screenshot 2022-05-06 21 02 53

... you get the idea :-)

from adoptium.net.

tellison avatar tellison commented on July 3, 2024

Seeing multiple times where the thank you box is not being populated on a page load.

I suspect that if the random page selected only has one contributor (a bot) then the current fix loops forever, so should choose another random page and contributor if a bot was initially selected.

from adoptium.net.

gdams avatar gdams commented on July 3, 2024

Ahh yes, some wonky coding from me there, I guess we need to add a second check and break the while loop once we have an acceptable contributor

from adoptium.net.

tellison avatar tellison commented on July 3, 2024

if the selected contributor is a bot, just pick an entirely new page and try again. It's random, not fair :-)

from adoptium.net.

hendrikebbers avatar hendrikebbers commented on July 3, 2024

@zdtsw @gdams can we close this issue?

from adoptium.net.

gdams avatar gdams commented on July 3, 2024

I think this can be closed, it doesn't seem to be an issue anymore

from adoptium.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.