GithubHelp home page GithubHelp logo

Comments (9)

sophia-guo avatar sophia-guo commented on June 29, 2024 1

Seems now tagged builds always trigger releaseType=weekly. In that case if we really need to regen all test jobs for each pipeline run, can simply add booleanParam(name: 'aqaAutoGen', value: true) as jobParams .

This is the solution for beta trigger builds regen test jobs, which is better than the changes in runAQATest() as this solution won't affect other vendor. @sxa

from ci-jenkins-pipelines.

sophia-guo avatar sophia-guo commented on June 29, 2024

Double checked. We did set GENERATE_JOBS=aqaAutoGen ( true for weekly run) https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L464 . So _testlist and _rerun jobs are also periodically regenerated. Not sure why there is warning with _testList or _rerun mentioned adoptium/infrastructure#2774 (comment) . Need more investigation. Close this.

from ci-jenkins-pipelines.

sxa avatar sxa commented on June 29, 2024

Double checked. We did set GENERATE_JOBS=aqaAutoGen ( true for weekly run) https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L464 . So _testlist and _rerun jobs are also periodically regenerated. Not sure why there is warning with _testList or _rerun mentioned adoptium/infrastructure#2774 (comment) . Need more investigation. Close this.

@sophia-guo Can you clarify what you mean by "weekly run" here? Is it

  1. the weekly-openjdkXX-pipeline such as https://ci.adoptium.net/job/build-scripts/job/weekly-openjdk21-pipeline/ or
  2. Any pipeline triggered with releaseType=Weekly which would include the tag-trigged builds.

I do not believe we are running from the weekend schedules since we are now building and running the full test suites from tags so the first of these are not being run.

Will the second of those options trigger a regeneration of the main test jobs as well as the testList/re-run ones? From your comment at adoptium/infrastructure#2774 (comment) it seemed like the testList/re-run ones would not currently be included in any regeneration. unless another parameter was added:

_There are two other types of test jobs naming as testList and rerun. Those jobs are generated if no jobs exist or if test job parameter GENERATE_JOBS is true, which currently can't be set by upstream weekly pipeline unless we add extra parameter.

but that seems to conflict with your last comment in here

So _testlist and _rerun jobs are also periodically regenerated.

I'm probably missing something obvious but it would be good to have clarity on whether all jobs including testlist and rerun ones will be done on every tag-triggered build i.e. case 2 above.

from ci-jenkins-pipelines.

sophia-guo avatar sophia-guo commented on June 29, 2024

@sxa the current weekly regen works for the weekly-openjdkXX-pipeline.

_testlist and _rerun jobs can be regenerated as long as we set aqaAutoGen=true. My former comment was wrong and that's why I double checked. Sorry for confusion.

from ci-jenkins-pipelines.

sxa avatar sxa commented on June 29, 2024

@sxa the current weekly regen works for the weekly-openjdkXX-pipeline.

_testlist and _rerun jobs can be regenerated as long as we set aqaAutoGen=true. My former comment was wrong and that's why I double checked. Sorry for confusion.

OK thanks - that's good to know (I didn't need to delete all the testList jobs yesterday after all I guess - although that was a useful exercise to clear up some old unused ones e.g. on the sanity.perf jobs)

If regen is only set for weekly-openjdkXX-pipeline It sounds like this needs to be reopened if we need to add an option into the tagged builds to enable regeneration generally (Could be another issue but this one was to cover having all the regular regenerations in place that are required)

FYI @andrew-m-leonard

from ci-jenkins-pipelines.

sophia-guo avatar sophia-guo commented on June 29, 2024

Seems now tagged builds always trigger releaseType=weekly. In that case if we really need to regen all test jobs for each pipeline run, can simply add booleanParam(name: 'aqaAutoGen', value: true) as jobParams .

from ci-jenkins-pipelines.

sophia-guo avatar sophia-guo commented on June 29, 2024

As test job params don't change frequently not sure if it is necessary to regen everytime. The regen does take time and resources. Meanwhile if we do regen everytime we might just remove the aqaAutoGen as parameter of pipeline and build jobs, which can be set directly in runAqaTests

from ci-jenkins-pipelines.

sxa avatar sxa commented on June 29, 2024

Seems now tagged builds always trigger releaseType=weekly. In that case if we really need to regen all test jobs for each pipeline run, can simply add booleanParam(name: 'aqaAutoGen', value: true) as jobParams .

Based on a conversation today it sounds like the regen is NOT triggered unless it's from the weekly-* pipelines, so there will be some work to enable regeneration in the beta triggered builds which have releaseType=weekly but aren't run via the weekly-openjdkXX-pipeline jobs.

from ci-jenkins-pipelines.

sxa avatar sxa commented on June 29, 2024

Thanks @sophia-guo - I think we're all sorted for the future with your PR!

from ci-jenkins-pipelines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.