adstrovers / 2015-02-11-web-inventory-manager Goto Github PK

search_for seems to return an array of hashes, not objects.

https://github.com/ADStrovers/2015-02-11-web-inventory-manager/blob/master/main.rb#L61

But that's not what I'd have gathered from: https://github.com/ADStrovers/2015-02-11-web-inventory-manager/blob/master/models/database_functions.rb#L70

---

list_all method seems to have been named within the context of "listing" things in Terminal... But now it's just returning all of the records. Please rename to all.

https://github.com/ADStrovers/2015-02-11-web-inventory-manager/blob/master/main.rb#L79

---

"/view?type=#{params[:type]}&id=#{@obj.id}" Totally awesome. Suggest moving into helper method, so that you could reuse the method in future route helpers too.

https://github.com/ADStrovers/2015-02-11-web-inventory-manager/blob/master/main.rb#L98

---

Tests look good 👍

---

More descriptive 'Returns' description please.

https://github.com/ADStrovers/2015-02-11-web-inventory-manager/blob/master/models/database_functions.rb#L26

---

Indentation.

https://github.com/ADStrovers/2015-02-11-web-inventory-manager/blob/master/views/view.erb