GithubHelp home page GithubHelp logo

Comments (9)

windj007 avatar windj007 commented on August 26, 2024

Hi! Thank you for your interest in our work!

L1 is not used and we just forgot to strip this parameter from the configs. Sorry for confusion.

from lama.

Marcelo5444 avatar Marcelo5444 commented on August 26, 2024

Therefore what is the a correct config in order to do finetunning on small masks, Celebhq small masks has L1 values mask not to zero, so I guess celebhq small mask was trained with L1 then?

from lama.

windj007 avatar windj007 commented on August 26, 2024

Could you please point, which config has nonzero l1 weight for missing areas?

from lama.

Marcelo5444 avatar Marcelo5444 commented on August 26, 2024

What I meant is that in previous post you said that L1 loss was not used but looking at the configs. It is used in may. One example of this is lama-celeba-hq/lama_small_train_masks

from lama.

Marcelo5444 avatar Marcelo5444 commented on August 26, 2024

Also, why You set the weight_know to 10, this is to force that the inpainted image as a similar aspect in out-of-mask zones?

from lama.

windj007 avatar windj007 commented on August 26, 2024

weight_known is only applied to parts of images outside the mask and it does not affect actual inpainting quality - you can safely switch it off. weight_missing is the weight of l1 inside mask - and it is set to 0 in all our configs. This is why I tell that L1 is not used.

Also, why You set the weight_know to 10, this is to force that the inpainted image as a similar aspect in out-of-mask zones?

Original motivation was like that, but later we figured out that this is not necessary. weight_known is there just for historical reasons - and it can be safely removed

from lama.

Marcelo5444 avatar Marcelo5444 commented on August 26, 2024

Can you point me to configurations trained with CelebHQ that weight_known is set to 0. In all of them weight_known is set to 10 and affects the training.

from lama.

windj007 avatar windj007 commented on August 26, 2024

I did not tell that we have weight_known=0 in any configs. The point is that the resulting quality does not depend on this parameter be it 0 or 10 or 100.

from lama.

windj007 avatar windj007 commented on August 26, 2024

I'm closing the issue for now. If you have any other questions, feel free to reopen it or create a new one.

from lama.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.