createdAt on addInterfaceInteraction action is empty about adyen-commercetools

[butenkor]

Hi @lojzatran. This error is actually caused by extension module and thus prevents notification module from adding the interaction, right?

It might be useful in case of 5xx errors to log whole payment and not just payload with actions, wdyt?

[lojzatran]

I tried the action in impex and got this error back:

{
  "statusCode": 400,
  "message": "The value '{}' is not valid for field 'createdAt'. ",
  "errors": [
    {
      "code": "InvalidField",
      "message": "The value '{}' is not valid for field 'createdAt'. ",
      "action": {
        "action": "addInterfaceInteraction",
        "type": {
          "typeId": "type",
          "key": "ctp-adyen-integration-interaction-notification"
        },
        "fields": {
          "createdAt": {},
          "status": "AUTHORISATION",
          "notification": "{\"NotificationRequestItem\":{\"additionalData\":{\"expiryDate\":\"10/2020\",\"authCode\":\"39697\",\"cardSummary\":\"1142\"},\"amount\":{\"currency\":\"EUR\",\"value\":495},\"eventCode\":\"AUTHORISATION\",\"eventDate\":\"2019-07-03T19:19:30+02:00\",\"merchantAccountCode\":\"CommercetoolsGmbHDE775\",\"merchantReference\":\"paymentReferenceId\",\"operations\":[\"CANCEL\",\"CAPTURE\",\"REFUND\"],\"paymentMethod\":\"visa\",\"pspReference\":\"853562174370815K\",\"reason\":\"39697:1142:10/2020\",\"success\":\"true\"}}"
        }
      },
      "actionIndex": 1,
      "invalidValue": {},
      "field": "createdAt"
    }
  ]
}

In the error above, it is indeed 500 error from extension, but I cannot reproduce this behaviour. However, the root cause here is the empty createdAt, which should not be sent at all. Once we solve it, we can check for other errors.

[lojzatran]

I investigated this error on my local machine and found out the following:

1. Missing value {} for createdAt is just a log issue. We pass createdAt: new Date() as an action to ctpClient and somehow when we got an error back, this is being displayed as createdAt: {}. This I solved by passing createdAt: new Date().toISOString() instead. So when we create an action from notification module, we pass the correct date value, but the logging for error just displays it wrong.
2. The real problem lies in extension module. We got this error:

"Unexpected token , in JSON at position 32518\\\",\\\"stack\\\":\\\"SyntaxError: Unexpected token , in JSON at position 32518\\\\n    at JSON.parse (<anonymous>)\\\\n    at _getPaymentObject (/app/src/api/payment/payment.controller.js:53:30)

The error is in this line const requestBody = JSON.parse(body) from this method:

async function _getPaymentObject (request) {
  const body = await httpUtils.collectRequestData(request)
  try {
    const requestBody = JSON.parse(body)
    return requestBody.resource.obj
  } catch (err) {
    throw new Error(`Error during parsing CTP request: '${body}'. Ending the process. `
      + `Error: ${JSON.stringify(serializeError(err))}`)
  }
}

So this means that the request does not contain complete JSON and cannot be parsed. However, when I tested on my local, there was no error. I tried multiple times and they all returned correct results.

[butenkor]

It cannot be reproduced anymore.