The Rails date_helper can choke when validates_timeliness finds a date to be invalid. about validates_timeliness

[Grammarella]

I should mention that for me, ValidatesTimeliness.enable_datetime_select_extension! doesn't just add something nice (the idea of displaying the bad date). If I do not have that line, the gem does not work for me at all. What I mean is that without that line, a bad date passes by as it does in normal Rails, with November 31st becoming December 1st, and no error is raised.

[dzajic]

+1 in Rails 3

[gjb83]

+1 in Rails 3.0.5

[brendon]

+1 for Rails 3.

[miskander]

I created a fork with a patch for v2.3. Unfortunately I do not have an install of Rails 3 to fix the latest release, but I will try to look at it. If you have Rails 2.3.5 you can look here for the fix: https://github.com/miskander/validates_timeliness. It was submitted to ruby gems, see http://rubygems.org/gems/markos_validates_timeliness.

[adzap]

Is this resolved in Rails 3?

[Grammarella]

I believe it is mostly resolved in Rails 3. I have just been able to migrate to Rails 3.2.8, and now the bad date is usually shown in the date_select when there are errors.

I say "mostly," and "usually," because there is one case where it does not work. If the bad date is within a nested object, and the date_select is therefore within a nested form, then the entire date gets wiped out. I believe this happens before returning to the view. Basically, the validation from validates_timeliness runs fine, and correctly adds the error for a bad date. This validation is in the model of the nested object. In that same model, a separate validation to see that the date is not blank will also fire, making me think that the validation for the bad date may have wiped it out. Then, of course, the page shows no date when it reloads.

If the date is good, then it is still shown in the date_select. Only bad dates are cleared out.

I do have config.enable_date_time_select_extension! on in the gem's initializer. I am using validates_timeliness version 3.0.14. Any ideas?