Invalid Meridian times accepted by validates_datetime about validates_timeliness

[adzap]

I suppose my thought was that AM and an hour > 12 is contradictory. Though both are invalid meridian times.

There is no option to change this behaviour, it requires a code change. For the v3 it requires a change to the Timeliness gem, which is not great problem.

Which version of the plugin are you using?

[vhalis]

I'm using 3.0.5 of validates_timeliness and 0.3.3 of timeliness.

PM and hour > 12 should be contradictory too, no?

[adzap]

Yes, perhaps.

I went to add a failing spec in Timeliness to test the behaviour and it should currently return a nil value. This is because it will try to make a time instance with an hour of 13 + 12 (for PM) which will throw an error.

Can you give me a failing spec for this?

[vhalis]

I can't figure it out. I've tried to make a failing spec in both timeliness and validates_timeliness, and neither one will make a time from "13:00pm." I made this test in validator_spec:

     it "is a test" do
     person.birth_datetime = "13:00pm"
     person.invalid?
     person.birth_datetime.should eql(52) 
     person.errors[:birth_datetime].should_not be_empty
 end

and inserted it at line 134. person.invalid? does not fail (same results with person.valid?), but person.birth_datetime.should eql(52) tells me that birth_datetime is nil. However, on my own testing with a model that has validates_datetime for :departure, and with b.departure = "13:00pm", using b.departure.to_s gives me 2011-02-16 13:00:00 UTC.

Any ideas?

[vhalis]

I made the smallest rails app I could to try and isolate the problem, and with only one model that has only a datetime and no other gems added to the Gemfile except validates_timeliness, I can assign "13:00pm" to my model and it turns into "13:00:00."

I uploaded it here: https://github.com/vhalis/validates_datetime-Meridian-PM-times

I'm really not sure what's going on, sorry. :(

[adzap]

I think the problem is that you don't have the plugin parser turned on. This is done in the config initializer output by the generator. You are possibly seeing the regular time parsing of this value.

[vhalis]

I ran the generator for the install and uncommented the config.use_plugin_parser and set it to true. However, the test still has the same result. Also pushed new version to github.

[adzap]

I've tracked it down to the railtie not loading the ActiveRecord extension by default, meaning the parser was not being used. If you uncomment the config.extend_orms [ :active_record ] line in the initializer it works as expected.

Will look into a fix.

[adzap]

Closing this and opening a new issue with description pointing here.

[vhalis]

Thanks a bunch, things work as expected with that. Thanks for your time!