Comments (12)
Fixed on #109, thank you for the great help, @shimulch.
from create-graphql.
I guess the last commit from master is a good start. We could define this later, great job!
from create-graphql.
Hi, Is this issue open? Can I have a try?
Also how a tag should be selected to be cloned?
from create-graphql.
Go ahead @shimulch
from create-graphql.
@shimulch: hey, of course!
We should define a specific tag or commit hash in the generator to clone the repo, that variable should be easy to change since we can keep increasing it based on the boilerplate commits/releases.
I think a commit hash is easier for now since it doesn't require any changes in the boilerplate code.
I can't point the file to change it right now because I'm on cellphone but it should be in the generator-graphql init command.
@felippepuhle: can you specify which commit hash is the best to clone the boilerplate at the moment? I think it should be one before the changes to the loaders.
from create-graphql.
Clone happens here https://github.com/graphql-community/create-graphql/blob/fbb25fa3adc7e8014bcfbb88220b708ff5fc1464/packages/generator/src/app/index.js#L42
from create-graphql.
@lucasbento Thanks for clarifications.
Here you can see my work so far.
master...shimulch:feature/clone_boilerplate_using_a_tag
It can now checkout to a specific commit hash after cloning the boilerplate. Now how you suggest to have a controllable variable for this task?
from create-graphql.
@shimulch: nice work!
I think you can keep it at the top as constant along with repository
so it can be easily changed.
@sibelius, @felippepuhle, @JCMais: can any of you tell me a commit hash to use?
from create-graphql.
I kept the last commit from master branch as commit hash. And its on a const to be changed.
from create-graphql.
@felippepuhle I have already put the last has from master in the PR. :-)
from create-graphql.
from create-graphql.
Yeah, I saw that @shimulch, thanks!
from create-graphql.
Related Issues (20)
- Creating a New Project Settings HOT 5
- UPDATE on npm HOT 2
- Updating create-graphql breaks other projects HOT 1
- Relay Modern frontend templates
- Update Loader templates
- Dockerizing environment HOT 3
- Hygen refactor
- throw error while generating type and mutation base on mongoose schema HOT 2
- Update builds to .circleci
- Integrate with plugin based system for dev to extend create-graphql
- Improve documentation by adding new methods and capabilities
- update generated files HOT 4
- add support for array field on mongoose HOT 4
- Use yarn on Lerna
- permit local installations HOT 3
- object notation should be optional HOT 2
- upgrade Loader templates HOT 1
- Update templates to handle ConnectionFromMongoCursor breaking change
- update loader templates
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-graphql.