Comments (2)
So the change in mapping from this PR: c23b443
Changed the mapping for GnssType::Beidou
which is causing the test to fail now as the previous GnssType::Beidou
is now associated with GnssType::Qzss
, is this expected behaviour?
If so it's a relatively simple change to update the data in the test to reflect the new mapping, if this is what indeed what is expected?
from nmea.
Actually, there was a typo in one of the mappings and when the typo was fixed (a wrongly associated TrackerId) the tests started failing.
These are the expected results but that was not the Beidou GNSS, to begin with, so this issue is abouting changing these expected values to Galileo
.
Lines 89 to 100 in c23b443
You can also see the excepted (left) vs the actual (right) from the failing test:
https://github.com/AeroRust/nmea/actions/runs/3074029877/jobs/4966543037
The talker ids are taken from here and the typo was fixed accordingly to this list: https://gpsd.gitlab.io/gpsd/NMEA.html#_talker_ids
PS: You also have to see if the tests succeed after this, there might be more places that need changing.
from nmea.
Related Issues (20)
- Formatting/serialization support
- [Docs] List all sentence-types features in lib.rs & README
- What is the MSRV? HOT 1
- Tags for versions 0.1 & 0.2 HOT 2
- AIS NMEA messages HOT 4
- Additional message types support HOT 1
- README update - Contributing & dual license
- Iterator-based parser
- Supporting additional sentences HOT 20
- Not all parts of a RMC sentence are parsed HOT 1
- Update README - what is NMEA 0183
- use `f64` (double) over `f32` precision in the Parser HOT 5
- Fix chrono deprecation warning
- MWV and MDA to "all supported messages" test HOT 1
- Update README/docs for a new release
- CI: Fix code coverage reporting
- Parsing of vendor-specific extended sentences that are not included in the `SentenceType` fails. HOT 3
- Enable sentences with features HOT 7
- Support defmt HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nmea.