GithubHelp home page GithubHelp logo

Fix failing test about nmea HOT 2 CLOSED

aerorust avatar aerorust commented on June 12, 2024
Fix failing test

from nmea.

Comments (2)

gybrish avatar gybrish commented on June 12, 2024

So the change in mapping from this PR: c23b443

Changed the mapping for GnssType::Beidou which is causing the test to fail now as the previous GnssType::Beidou is now associated with GnssType::Qzss, is this expected behaviour?

If so it's a relatively simple change to update the data in the test to reflect the new mapping, if this is what indeed what is expected?

from nmea.

elpiel avatar elpiel commented on June 12, 2024

Actually, there was a typo in one of the mappings and when the typo was fixed (a wrongly associated TrackerId) the tests started failing.
These are the expected results but that was not the Beidou GNSS, to begin with, so this issue is abouting changing these expected values to Galileo.

"{Beidou 2 Some(11.0) Some(112.0) None}",
"{Beidou 5 Some(28.0) Some(135.0) None}",
"{Beidou 7 Some(22.0) Some(49.0) None}",
"{Beidou 9 Some(2.0) Some(118.0) None}",
"{Beidou 10 Some(36.0) Some(54.0) Some(18.0)}",
"{Beidou 11 Some(20.0) Some(75.0) Some(18.0)}",
"{Beidou 12 Some(5.0) Some(29.0) None}",
"{Beidou 19 Some(0.0) Some(0.0) None}",
"{Beidou 20 Some(37.0) Some(296.0) Some(30.0)}",
"{Beidou 23 Some(66.0) Some(39.0) Some(17.0)}",
"{Beidou 25 Some(19.0) Some(68.0) None}",
"{Beidou 28 Some(3.0) Some(153.0) None}",

You can also see the excepted (left) vs the actual (right) from the failing test:
https://github.com/AeroRust/nmea/actions/runs/3074029877/jobs/4966543037

The talker ids are taken from here and the typo was fixed accordingly to this list: https://gpsd.gitlab.io/gpsd/NMEA.html#_talker_ids

PS: You also have to see if the tests succeed after this, there might be more places that need changing.

from nmea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.