Comments (27)
I really don't get why more users is the right idea here. I would highly suggest you reconsider this and instead use Github actions to publish the package.
If any of the users get their accounts compromised they'll be able to publish, automated publishing avoids this.
from agenda-rest.
@keyvan-m-sadeghi : That's awesome. I am in !!
from agenda-rest.
@sampathBlam great, can I have your NPM username?
from agenda-rest.
Very good suggestion @OmgImAlexis, I wasn't aware that GitHub actions supports this use case. Also I noticed that I actually don't have admin rights over the repo. Could you please help with setting this up with best practices?
from agenda-rest.
Don't have a great deal of spare time but this should help and I'm free to answer questions you have. I'd suggest making the publish happen on new commit to master that way it'll only happen when we merge a PR, or push directly to master.
from agenda-rest.
I'm available too. I can help with setting up Github actions.
from agenda-rest.
Great @geosp, I really haven't found the time to go about it.
@OmgImAlexis appreciate if you can give @geosp write access to the repo, I can do the npm side.
from agenda-rest.
@keyvan-m-sadeghi and @OmgImAlexis I will do my best to help. I notice that the build was failing for a long time so I took the time to fix that too in my latest PR #93 . Thank you.
from agenda-rest.
Looks good @geosp, what's your username on npm?
from agenda-rest.
It is gffajardo.
from agenda-rest.
@keyvan-m-sadeghi and @OmgImAlexis Any word regarding access or PR #93 ? I know you are busy, please let me know. Thank you.
from agenda-rest.
Invite should have been sent on GitHub sorry for it taking so long.
from agenda-rest.
Thank you @OmgImAlexis
from agenda-rest.
@keyvan-m-sadeghi Any word in regards to NPM access?
from agenda-rest.
Sorry @geosp been away for a few days. I just checked npm and noticed I no longer have admin access there.
@OmgImAlexis can you give write access to @geosp on npm? Username is gffajardo
.
Great work on refactoring @geosp
from agenda-rest.
Thank you @keyvan-m-sadeghi. I want to use this PR to test deploying to npm using GitHub actions. I assume you approve of the changes in #94 .
from agenda-rest.
Yeah all good 👌
Did you get the npm access? I have write access but not admin, let me know if I can help with anything @geosp
from agenda-rest.
@geosp I'm trying to give you access through the "teams" feature of npm, check your email for an invite from "assister" org and let me know if that gives you write access to the agenda-rest
package
from agenda-rest.
@geosp give me a hint when you accepted the invite, apparently there's an additional step I need to take before you actually get write access (adding you to agenda-rest-write
team, which requires being a member of the assister org first, I'm not sure even @OmgImAlexis can add new members now, seems I've created this package under this username first then changed it to an org at some point, which is causing all this trouble).
from agenda-rest.
@keyvan-m-sadeghi Thank you for your assistance. I'm in the org now.
from agenda-rest.
@geosp done, you now have write access to the npm package. You need to enable 2FA in your npm account to publish though.
Feel free to merge pull requests as they come in, welcome aboard!
from agenda-rest.
Thank you, guys. I got really busy there for a while. I will be working on the GitHub-actions task now.
from agenda-rest.
@keyvan-m-sadeghi and @OmgImAlexis Hello guys. I created an issue for the implementation of GitHub actions and a PR to resolve the issue. Please take look at PR #96 .
from agenda-rest.
@OmgImAlexis Can you please add the NPM security token to GitHub so that the workflow is able to publish the library to NPM. Thank you so much for your help.
from agenda-rest.
I was able to publish the new version manually, but it will be nice to have it done automatically.
from agenda-rest.
Sorry that I've been away @geosp, it is indeed nice to automate publishing, hope @OmgImAlexis reads this as I don't have admin rights for the repo to give you the keys.
from agenda-rest.
Also thanks for the great work on updating everything @geosp
from agenda-rest.
Related Issues (20)
- Migrate tests to Mocha
- Missing documentation on how to define jobs HOT 4
- got 404,why HOT 2
- Cannot find module './settings'
- How to repeat job at Friday at 5am for every week HOT 2
- Must run on port 8080? Failure ECONNREFUSED 127.0.0.1:8080 HOT 3
- Not maintained anymore? HOT 6
- How to introduce logging
- Params Does not Work when is pased to schedule a Job HOT 7
- How to secure the rest endpoint HOT 11
- Provide information about the CLI arguments in the documentation HOT 3
- [Question] How good or bad it would be if we replace the command line options with a config json which the agenda-rest service can use when we launch it? HOT 2
- The job fails when specifying port number, parameters and query strings.
- Allow options as a parameter when creating jobs. HOT 3
- How do I deploy this on heroku? HOT 1
- POST to /job/every consistently 'overwrites' last job instance with same name HOT 1
- Implement support for passing agenda settings via the CLI
- There is a mismatch between the npm package version and the sour code package.json.
- Implement GitHub actions.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from agenda-rest.