Comments (13)
Now that npm v7 has been released, this is becoming more of a blocker to upgrading. npm@7 throws an error if peerDeps cannot be resolved correctly.
from react-signature-canvas.
Released in v1.0.5
from react-signature-canvas.
Yea was planning on making that change soon. Should probably work fine with React 17 since it only changes event capture and react-signature-canvas
and signature_pad
don't rely on React's event capture.
I'll have to update the devDep and make sure tests pass first. Might get to it in the coming week as I've been looking to get back to this library and make some merges I put off.
In any case, it's just a warning, so it should not be a blocker.
from react-signature-canvas.
Would you accept a PR if everything works? I like to strictly follow peerDependency ranges so this may block our upgrade soon.
from react-signature-canvas.
Would also be open to lend a hand if needed
from react-signature-canvas.
Hi, would like to know when the solution will be released. Knowing this will come together with other important fixes but just want to confirm the date.
from react-signature-canvas.
Are we adding support for React 17? I tried to upgrade the react in a fork, but getting some issues running the test after upgrading enzyme.
from react-signature-canvas.
any quick workaround to make this work on react 17?
edit:
found this compatible version https://www.npmjs.com/package/react-signature-canvas-react17-compatible
from react-signature-canvas.
@agilgur5 can we get an update on this? Cheers
from react-signature-canvas.
@agilgur5 It would be nice to have this ASAP
from react-signature-canvas.
Hi all. I have created an npm package as a workaround for the React 17 issue https://www.npmjs.com/package/react-signature-drawing. This has a direct dependency on this project. This should be used until agilgur5 is back
from react-signature-canvas.
Hi @luke9216 how to use your package?
from react-signature-canvas.
Any plan when React 17 support will be added?
from react-signature-canvas.
Related Issues (20)
- issues in latest Google Chrome 117 HOT 4
- Cannot get SVG data url after `getTrimmedCanvas()` HOT 3
- working in localhost but when published not working on dev env HOT 1
- Saving and Restoring DataURL results in smaller image HOT 1
- How to check if a dataURL is empty? HOT 1
- Update to `signature_pad` v4 for "passive" events? HOT 4
- `time` attribute only present in last stroke
- Convert raw array data (`toData`) to image so it can be scaled? HOT 5
- React 18 support in peerDeps HOT 9
- Custom CSS properties? (for custom cursor etc) HOT 1
- `TypeError: Cannot read properties of null (reading 'off')` during mount when running tests for a wrapper component HOT 8
- `onBegin` not called when `fromData` invoked HOT 1
- `TypeError: undefined is not an object (evaluating 'this._data[this._data.length-1].push')` HOT 1
- `TypeError: sigCanvas.current.getTrimmedCanvas is not a function` HOT 1
- `TypeError: sigCanvas.current.getTrimmedCanvas is not a function` HOT 2
- Background Image lost while converting `toData` and back with `fromData` ("undo" operation) HOT 2
- support for `redrawOnResize` func HOT 2
- Weird artifacts using Next.js 13 HOT 3
- Stroke offset with Next.js prod build HOT 2
- What is the difference between SignaturePad and SignatureCanvas? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-signature-canvas.