GithubHelp home page GithubHelp logo

Comments (13)

mihkeleidast avatar mihkeleidast commented on May 19, 2024 26

Now that npm v7 has been released, this is becoming more of a blocker to upgrading. npm@7 throws an error if peerDeps cannot be resolved correctly.

from react-signature-canvas.

agilgur5 avatar agilgur5 commented on May 19, 2024 1

Released in v1.0.5

from react-signature-canvas.

agilgur5 avatar agilgur5 commented on May 19, 2024

Yea was planning on making that change soon. Should probably work fine with React 17 since it only changes event capture and react-signature-canvas and signature_pad don't rely on React's event capture.

I'll have to update the devDep and make sure tests pass first. Might get to it in the coming week as I've been looking to get back to this library and make some merges I put off.

In any case, it's just a warning, so it should not be a blocker.

from react-signature-canvas.

mihkeleidast avatar mihkeleidast commented on May 19, 2024

Would you accept a PR if everything works? I like to strictly follow peerDependency ranges so this may block our upgrade soon.

from react-signature-canvas.

ctrlaltdylan avatar ctrlaltdylan commented on May 19, 2024

Would also be open to lend a hand if needed

from react-signature-canvas.

JenRuey avatar JenRuey commented on May 19, 2024

Hi, would like to know when the solution will be released. Knowing this will come together with other important fixes but just want to confirm the date.

from react-signature-canvas.

durgeshrkumari avatar durgeshrkumari commented on May 19, 2024

Are we adding support for React 17? I tried to upgrade the react in a fork, but getting some issues running the test after upgrading enzyme.

from react-signature-canvas.

ashen780 avatar ashen780 commented on May 19, 2024

any quick workaround to make this work on react 17?
edit:
found this compatible version https://www.npmjs.com/package/react-signature-canvas-react17-compatible

from react-signature-canvas.

luke9216 avatar luke9216 commented on May 19, 2024

@agilgur5 can we get an update on this? Cheers

from react-signature-canvas.

filkalny-thimble avatar filkalny-thimble commented on May 19, 2024

@agilgur5 It would be nice to have this ASAP

from react-signature-canvas.

luke9216 avatar luke9216 commented on May 19, 2024

Hi all. I have created an npm package as a workaround for the React 17 issue https://www.npmjs.com/package/react-signature-drawing. This has a direct dependency on this project. This should be used until agilgur5 is back

from react-signature-canvas.

jmalbite avatar jmalbite commented on May 19, 2024

Hi @luke9216 how to use your package?

from react-signature-canvas.

Sean-Y-X avatar Sean-Y-X commented on May 19, 2024

Any plan when React 17 support will be added?

from react-signature-canvas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.