AdBlock enhancement about agregore-browser

[RangerMauve]

Yeah, I'd be down for a faster approach to detecting URLs to block.

The perf changes might need to be done in the electron-extensions module, but we could also try to do them in the extension.

Not sure if blocking stuff based on URL content is the best idea though since it can lead to false positives. 🤔

[KyGost]

After giving this a go it wasn't worth it.
Perhaps there is something better we can do. It'd be good to test the true time it takes to run the adblock, perhaps it is just psychological.

[KyGost]

This looks even longer than our current list, whilst perhaps it may improve ad blocking, it wouldn't improve the performance hit.

[KyGost]

Yeah, I ended up deciding that perhaps the best approach to have a middleground of efficiency and quality is to condence the list into regex which captures 95%(or more?) of the list and then if it is captured, it is searched.

So perhaps a config file for the extension in the extension files, default to regex + HTTP/S only but options of:

• Everything
• HTTP/S only
• HTTP/S only + regex

I'll write it up some time

[zoonderkins]

Suggestion adblock list: https://abp.oisd.nl/light