GithubHelp home page GithubHelp logo

Comments (4)

ramayer avatar ramayer commented on June 26, 2024

If I read the code right - the problem is that the * in "*args" was getting applied twice, while it should have been applied once.

It got applied once by pipe_result's 'block.call(*args)'.
And then again byforkoff's 'Forkoff.send( strategy_method, *args, &block ).

I made a patch removing one of those calls and it seems to make it work as expected for me.

http://github.com/ramayer/forkoff/commit/e0b6ba20ecfc1d6d0854c13aec3d5c109eb77d2b

from forkoff.

marcandre avatar marcandre commented on June 26, 2024

Yeah, there was a confusion in the code. In particular, the args in each_with_index(args, i) should have been singular. Fix with tests in http://github.com/marcandre/forkoff/commit/4ad80bb3f4a4d58ca3dd23f8bb4e9e0149e2ad06

from forkoff.

ramayer avatar ramayer commented on June 26, 2024

Any chance that'll be pushed as a new gem?
The command
gem install forkoff
still seems to install the broken version.

from forkoff.

ahoward avatar ahoward commented on June 26, 2024

v1.2.0 has this fix.

from forkoff.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.