GithubHelp home page GithubHelp logo

Comments (14)

aiekick avatar aiekick commented on July 20, 2024 1

Hello,

ok thanks, i will test.

can you give your font file for a test case ?
if you cant, can you open the merged font file in the soft and show the result.
if you not see the glyph, display the glyph panel and select it in the current font pane, for see the result.
maybe its merged but maybe theses glyph are very very small.
i had the case with my tests.

what are the resolution of the two fonts you use ?
maybe one is very small compared to other ?

the best case is to have two font with exactly same ascent/descent and baseline for the moment.

for the moment the quick thing you can do is to use the old way :

  • merge manually the glyphs you want from one font file to another font file via by ex fontforge.
    (like that you can adjust glyph size, pos and others things
  • use this merged file for generate in ImGuiFOntStudio the cpp/headers files.

from imguifontstudio.

aiekick avatar aiekick commented on July 20, 2024 1

i have maybe another explain.

there is two type of font glyphs.
the simple glyph and the compound glyph.
Compund glyph is composed of many other glyph available in font.

ImGuiFontStudio can export for the moment only simple Glyph.
so if your glyph is a compund he is empty in the merged font

Edit : i have tested and indeed its a bug. many glyphs seems not exported. and they are all simple glyphs. i will check that tonight :)

from imguifontstudio.

aiekick avatar aiekick commented on July 20, 2024 1

had some issue on last fix for macos/linux. but its fixed now. so you can pull

from imguifontstudio.

selimanac avatar selimanac commented on July 20, 2024 1

Sorry for late response. This works great, thank you :)

from imguifontstudio.

aiekick avatar aiekick commented on July 20, 2024 1

i found, the cmap table who is responsible of glyph mapping, is badly generated.
so maybe on some font like yours cause some border effect on some glyphs.
i seen crash of stb_truetype with my generated font..

from imguifontstudio.

selimanac avatar selimanac commented on July 20, 2024 1

it seems your two fonts have issue. in fontforge when you go in menu : element / validation (for french menu)

he found many errors on many glyphs ,and seem to be the glyphs we not see after merge.
like the Root glyph

This was really helpful, thank you. I clean all errors by using Fontforge.

from imguifontstudio.

selimanac avatar selimanac commented on July 20, 2024

can you give your font file for a test case ?

Fonts and .ifs file is attached below.
fontstudio.zip

what are the resolution of the two fonts you use ?
maybe one is very small compared to other ?

They should be same because I draw some of them . If they are not then I made a mistake when drawing.

the best case is to have two font with exactly same ascent/descent and baseline for the moment.

Sorry, I have no idea about that. I use icomoon.io to prepare icons/fonts

merge manually the glyphs you want from one font file to another font file via by ex fontforge.
(like that you can adjust glyph size, pos and others things
use this merged file for generate in ImGuiFOntStudio the cpp/headers files.

I will, thank you.

from imguifontstudio.

aiekick avatar aiekick commented on July 20, 2024

the glyph re write can produce some time a bad format of font file.
i not seen that with my fonts, but he is with your font.

i found its due to maybe one glyph who produce bad rewrite and a corrupted file
with other or less selection some time it work some time not.
will be difficult to found why, but its interesting.

by the way for the moment i have added a option for disable the glyph rescale, if the user want.
Glyph rescale is needed if font ascent/descent are different. in your case its same.
but the glyph resize in fact is according the bounding box of each glyph.

btw with this option (in generator pane in settings), each glyphs are just moved from one font to the merged font result. no rewrite, no corruption, but no rescale/translation, so some glyph can be badly positionned regarding other.

if you need to adjust some glyphs, you can modify if with fontforge (edit the glyph you want), and finish the job in ImGuiFontStudio :)

see :
WWrnxciblJ
To note :
The quick button i use is only available in debug mode, no impact on the normal way.
The result will be same

from imguifontstudio.

aiekick avatar aiekick commented on July 20, 2024

it seems your two fonts have issue. in fontforge when you go in menu : element / validation (for french menu)

he found many errors on many glyphs ,and seem to be the glyphs we not see after merge.
like the Root glyph

So the question is : how can we avoid issue with bad glyph format :)

from imguifontstudio.

selimanac avatar selimanac commented on July 20, 2024

how can we avoid issue we bad glyph format :)

Yeah, it is my bad :) Sorry about that. I don't know much about glyph. I have Fontforge installed but looks too complex to me. So I did use the icomoon.io for generating fonts from my svg files. I draw those svg's at Illustrator by using Material Icons guideline. But it is highly possible that I did some mistakes when drawing. Also it is possible that icomoon.io is failling at some point and cause this problem.

I will definitely check out the Fontforge properly.

Thank you.

from imguifontstudio.

aiekick avatar aiekick commented on July 20, 2024

np, its interesting, all the softwares can avoid the issue and generate good font.
so i need to do same. just to found the exact issue in my generation and found a solution :)

and its in my plan to have the possibilite to draw glyph and merge svg, so at a moment i need to be robust for this generation :)
thanks np :)

from imguifontstudio.

aiekick avatar aiekick commented on July 20, 2024

so, after glyph correction in font forge, the merge in ImGuiFontStudio was ok ? this is that ?

from imguifontstudio.

selimanac avatar selimanac commented on July 20, 2024

so, after glyph correction in font forge, the merge in ImGuiFontStudio was ok ? this is that ?

Yes it is. It is ok in ImGuiFontStudio. Problems was about my faults(drawing directions and wrong compound paths may cause fail).

from imguifontstudio.

aiekick avatar aiekick commented on July 20, 2024

ok good to hear. i will try to detect and correct bad path so.
thanks

from imguifontstudio.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.