[Feature] Supplier address issues in checkout about aimeos-core

[aimeos]

You can add arbitrary information as order service attributes which you can display in the summary and e-mail later on: https://aimeos.org/api/latest/class-Aimeos.MShop.Order.Item.Base.Service.Iface.html#_setAttributeItem

[nvindice]

Thank you, tried that and it works well. However, the additional attribute is missing in the confirmation e-mail. The decorator does not even seem to get called at all here. What am I missing?

[aimeos]

The decorator is only called on the checkout delivery page and you have to add the information you want to store as order service attribute. At the summary page and in the e-mail you can only display the information that have been stored as order service attributes.

[nvindice]

I use this code in the getConfigFE() function of my decorator:

$service->setAttributeItem( new \Aimeos\MShop\Order\Item\Base\Service\Attribute\Standard( array(
	'order.base.service.attribute.code' => 'delivery-supplier.address',
	'order.base.service.attribute.value' => $addressShort,
) ) );

It definitely gets executed, the information is displayed at the summary page automatically, but it's missing in the e-mail...

[aimeos]

Is it stored in the mshop_order_base_service_attr table for the order?
If it is available it should be displayed:

• https://github.com/aimeos/ai-client-html/blob/master/client/html/templates/common/summary/service-standard.php
• https://github.com/aimeos/ai-client-html/blob/master/client/html/templates/email/common/text-summary-service-partial-standard.php

[nvindice]

No it isn't. So it looks like I did not fully understand the Controller system, and the $service object I use is just a copy, not a reference. I'm still an Aimeos newbie, sorry.

Where should I use the setAttributeItem() call? At which position in my decorator should I use which Service item?

EDIT: I found this handy function: $this->saveOrderBase( $basket ); - now the value is stored in the DB. Nevertheless, when I change pages during the checkout process a few times (Delivery -> Payment -> Summary -> Payment -> Delivery -> etc), the attribute is stored multiple times - each time with a new ordservid. Is this desired behaviour or can I optimize my code?

[aimeos]

saveOrderBase() is not meant to be used during the checkout process.

You can use the setConfigFE() in your decorator to add more data to the order:
https://aimeos.org/api/latest/class-Aimeos.MShop.Service.Provider.Iface.html#_setConfigFE

[nvindice]

Thanks, that was the missing bit. I created a PR with added functionality. There should be no breaking changes because the new functionality is controlled by the BE config parameters which default to the old behaviour.

Furthermore, the user manual should be updated here: https://aimeos.org/docs/User_Manual/Administration_Interface/Service_decorators

[aimeos]

Merged into the Aimeos Core