Comments (17)
How about custom scheme, something like unix://socket-path/path ?
from aiohttp.
Not sure it's a good idea for two reasons:
- socket-path should be percent-encoded? (may contain slashes)
- https can be used too (unix+https://socket-path/path?)
I prefer some kwarg to a request or a session.
from aiohttp.
i don't like percent-encoding also, but in that case we can move connection to to separate Connector class/function and remove loop.create_connection from session and client.
how about connector parameter? something like:
aiohttp.request('get', ..., connector=UnixDomainConnector('/tmp/...'))
then it would be possible to create http proxy connector for example
what do you think?
from aiohttp.
Yes. Sounds great
from aiohttp.
Paul, do you want to work on this?
from aiohttp.
Sure, unless you want to do it quicker :)
from aiohttp.
go ahead! :)
from aiohttp.
I'd love this feature oodles! Just adding a 👍 - thanks for working on this!
from aiohttp.
@tailhook let's wait with session integration with connector. i'd like to think about such integration.
from aiohttp.
@fafhrd91, ok, I don't need the feature itself. The debatable question, is that connector might be better used for connection pooling, instead of session. And session left only for cookie handling.
Anyway, feel free to close the issue if you think it done.
from aiohttp.
I'd really be able to use this feature; I'd be happy to test code or whatever :)
It'd be super useful!
from aiohttp.
@tailhook i agree about connection pooling, this is exactly what i'm planing to think about.
from aiohttp.
👍 consuming HTTP over unix sockets via aiohttp would be excellent; there are still plans to flesh out the rest of the interface so this is properly possible, right?
from aiohttp.
yes. i'm planing to commit api changes within next couple days.
from aiohttp.
Excellent, thanks for confirming ❤️
from aiohttp.
i've just commited new changes @ce21cba8869b8b80849850c1d645fe029dc054b2
from aiohttp.
This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.
If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.
from aiohttp.
Related Issues (20)
- TypeError: _patch_task.<locals>.task_new_init() got an unexpected keyword argument 'eager_start' HOT 5
- Sending default 'Server' header when failing on wrong HTTP method HOT 6
- Websocket ping test has transient failures on loaded systems HOT 1
- Send 100-continue only when handler reads body
- typing error with `timeout` argument of `aiohttp.ClientSession` requests methods HOT 1
- Rename compress parameter HOT 6
- on_request_headers_sent params type was never imported into the top-level file. HOT 2
- AsyncResolver not passing on loop too aiodns.DNSResolver HOT 4
- test_web_sendfile_functional isn't testing sendfile
- Incorrect re-use future in _make_or_get_ssl_context HOT 10
- ClientSession.get() doesn't support hostname.
- MIsing header file HOT 1
- Replace blockdiag HOT 1
- 3.9.2 server keep-alive timeout can cause disconnect of active connections and hence client server disconnect errors HOT 18
- Disable retry in tests
- add `Sequence[str | int]` typing in `_RequestOptions.params` HOT 2
- Middleware fix up is unexpectedly expensive HOT 2
- Regression in aiohttp 3.10.3 when running multiple loops in multiple threads HOT 2
- Remove make_mocked_coro()
- Replace aioredis in example
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aiohttp.