Traceback error with examples/srv.py and mpsrv.py about aiohttp

[fafhrd91]

example were out of date. should be fixed now.

[ludovic-gasc]

ok, than you a lot. An idea when it will be fixed ?
Could you re-open this issue and close when it will be fixed ? With that, others beta-testers and me will be alerted when the fix will be available.

[fafhrd91]

i fixed examples in @94883db00530ec6dc85b3f817c11f88dba69baac

[fafhrd91]

did you get different traceback with latest changes?

[ludovic-gasc]

Yes, now it works as excepted.
A small remark: If I understand correctly your source code in aiohttp/server.py, it should be good in examples to replace

response.write_eof()

by

drain = response.write_eof()

and add at the end of the method:

return drain

.

[fafhrd91]

there is no reason to return drain, drain is for write flow control and both Response.write and Response.write_eof methods return drain future. so if you want to use flow control you should do something like:

yield from response.write(payload)
yield from response.write_eof()

[ludovic-gasc]

Ok, thank you for your answer, I understand better.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.