GithubHelp home page GithubHelp logo

aiohttp.HttpClient about aiohttp HOT 6 CLOSED

aio-libs avatar aio-libs commented on June 25, 2024
aiohttp.HttpClient

from aiohttp.

Comments (6)

fafhrd91 avatar fafhrd91 commented on June 25, 2024

i have two use case at the moment for this class:

  1. you can configure schema, host, port once and then use only paths to access your service. for example
client = aiohttp.HttpClient(hosts=['...'])
yield from client.request('/path1')
yield from client.request('/path2')
  1. if you have multiple servers or load balancers and you want to access all of them (example is riak)

i'd rather see hooks for custom failure detection than removing this class.

from aiohttp.

asvetlov avatar asvetlov commented on June 25, 2024

In private chat with @fafhrd91 we decided to leave HttpClient for now.
Closing the issue.

from aiohttp.

ludovic-gasc avatar ludovic-gasc commented on June 25, 2024

Hi @asvetlov, I'm not agree with you.
For me, aiohttp handles HTTP (Client, Server, Websockets, Gunicorn) for AsyncIO Python world. From my point of view, not a good idea to split this project to several projects because:

  1. The source code size is small, easy to find information inside, it isn't a spaghetti source code that need to split.
  2. Few people is contributing on this project, easier to contribute if everything is in the same place.

Nevertheless, Client API could be improved to be easier to use, and also error handling.

from aiohttp.

asvetlov avatar asvetlov commented on June 25, 2024

I don't want to split aiohhtp to several projects.
From my perspective the HttpClient is not good citizen for Public API, that's all.
I'm ok for keeping it for a while.

Have you some ideas for improvement Client API and error handling?
Please make an issue if you have some proposal.

from aiohttp.

ludovic-gasc avatar ludovic-gasc commented on June 25, 2024

I don't made enough code with Client API to have a pertinent opinion for now.
My main issue was about headers handling, I had write more code that with Requests because it wasn't a dict but a deque, but this problem is solving (#62), thanks to you ;-)

from aiohttp.

lock avatar lock commented on June 25, 2024

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

from aiohttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.