GithubHelp home page GithubHelp logo

Comments (4)

rossbacher avatar rossbacher commented on August 17, 2024 1

Sorry it took that long but this is fixed now and in release https://github.com/airbnb/DeepLinkDispatch/releases/tag/5.3.0.

from deeplinkdispatch.

rossbacher avatar rossbacher commented on August 17, 2024

I'll have a look at that. I don't think we have a test case for this and thus it might have been missed.

from deeplinkdispatch.

stari4ek avatar stari4ek commented on August 17, 2024

There is a chance that incremental build is involved.
I had same issue. Bunch of "foo://navigate/*" declared, but only one was added to registry.

It looks like it swallows errors, so only part of entries are added. And it stays unchanged on next build.

I had:

@AppDeepLink({"tv/{what}"})
public static Intent intentForTv(@NonNull Context context, @NonNull Bundle extras) {

Dropped placeholder from link:

@AppDeepLink({"tv"})
public static Intent intentForTv(@NonNull Context context, @NonNull Bundle extras) {

No errors, but registry got 2 entries only (10+ expected).
Changed signature:

@AppDeepLink({"tv"})
public static Intent intentForTv(@NonNull Context context) {

Same broken registry.
Forced to rebuild project => registry recovered.

Updated:

Maybe I'm hi-jacking the issue after all. According to initial report - registry is populated with both entries which is different from my case when registry become broken.
I have disabled kapt.arguments.deepLink.incremental and do not have issues so far:

@AppDeepLink({
    "navigate/tv/{kind}",
    "navigate/tv/{kind}/{id}"
})

produces:

new DeepLinkEntry("myapp://navigate/tv/{kind}/{id}", DeepLinkEntry.Type.METHOD, DeepLinksTvNavigation.class, "intentForTv"),
new DeepLinkEntry("myapp://navigate/tv/{kind}", DeepLinkEntry.Type.METHOD, DeepLinksTvNavigation.class, "intentForTv"),

and both are resolved as expected.

from deeplinkdispatch.

cvillaseca avatar cvillaseca commented on August 17, 2024

Thank you for the fix @rossbacher 🙏

from deeplinkdispatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.