Comments (2)
@imrehg - Thanks for posting this. We are experimenting with these devcontainers as a means of streamlining community contributions as well as maintainer's code review processes. Your proposals to bump the version sound good to me. If you are able to contribute a PR, please tag me as reviewer and I'll happy review and approve.
We could also consider reverting to the "universal" image that Github/Microsoft are maintaining - while it is a larger image, it comes pre-loaded with Python and Node (to host VS Code and its extensions) and the universal image appears to be cached on runners and has a faster build times. (Not based on controlled experiments, just based on anecdotal observations.) On the negative side, I've had sporadic problems git committing (PGP error) on the universal image, although that may have been a one-time fluke.
Long-story short, we welcome your suggestions and I appreciate your posting this issue. Lmk how I can help! 🙏
from airbyte.
@aaronsteers I've submitted a PR with the proposed second option, to minimise the changes and focus on making the environment better fit for purpose.
Now that I can run the dev container, I can see that that the actual developer flow is indeed quite experimental in there, partly because it's new to me (so I'm not sure if everything has been set up correctly), and partly because it seems like the container does make the various config more mixed up (mapping config from the dev machine into the cotnainer).
As some illustrative examples, I use ssh key signing, and most config is loaded fine except the allowed signing keys file, since it's referring to the location outside of the container. Also had some issues getting the pre-commit hook work (I didn't). These bits are something to explore in a separate PR, probably. And that motivated me to keep this, rather than switching to the universal image, as I wouldn't be sure which issues that I encounter is due to the image change versus all the other setup. I can see that move would simplify the setup though, so likely it's a fitting suggestion for later.
from airbyte.
Related Issues (20)
- Destination Bigquery: When raw data set changed away from `airbyte_internal`, `airbyte_internal` is still being creataed HOT 3
- [destination-postgres] sync hangs indefinitely with no error HOT 1
- [source-oracle] Cannot connect to a database with an internally-signed certificate
- Orchestrator handles heartbeat 410 properly
- [source-shopify] transactions receipt ingested as string instead of object
- Connector Pipedrive: custom fields do not sync HOT 1
- Platform speed has dropped since January 2024
- [placeholder] spike for implementing RFR in python cdk
- replace all instances of AirbyteLogger
- Storybook site (components.airbyte.dev) down, no DNS records HOT 1
- airbyte-ci tool using broken dependency HOT 3
- Bake in latest CDK versions at build time (in addition to on boot + cron)
- [source-facebook-marketing] Ad Insights schema missing video_thruplay_watched_actions field HOT 1
- [source-klarna] incorrect config.region values: change 'us' --> 'na' HOT 1
- Temporal v1.23.0 fails to start with error: Unable to create SQL database, but v1.20.1 works fine. HOT 3
- [source-zendesk-support] Please switch to Cursor Pagination at the earliest HOT 1
- [helm] Minio create bucket : permission denied HOT 4
- [source-stripe] 100% of CPU and fails after a few hours HOT 1
- Revisit pagerduty alerts
- Getting error "Could not resolve placeholder ${AIRBYTE_API_HOST}" when trying to call the API HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from airbyte.