GithubHelp home page GithubHelp logo

Comments (5)

mattmceuen avatar mattmceuen commented on August 11, 2024 1

Thanks @sirajyasin ! A couple thoughts on how to approach it:

  1. make this line conditional, based on an input/override to AIAP: https://github.com/airshipit/airshipctl/blob/master/tools/airship-in-a-pod/runner/assets/entrypoint.sh#L77
    This^ is because we still want to regenerate/show secrets in our gates, but when we're testing an integration that uses real-life credentials in the manifests, we want to neither regenerate nor show!

  2. provide the decryption key to AIAP via a kind: Secret. The base kustomization could define the contents of this to include the mozilla key, and there could be a placeholder and/or documentation on how to kustomize a real key on top of it

  3. add documentation on how to use a custom key to the AIAP README

  4. (probably outside the scope of this issue, & should be a follow-on) it would be great to leverage #2 to mount in azure key vault-hosted keys, perhaps using this feature: https://docs.microsoft.com/en-us/azure/aks/csi-secrets-store-driver

from airshipctl.

sirajyasin avatar sirajyasin commented on August 11, 2024

I can work on this issue if no one has started yet. Can someone assign this issue to me ?

from airshipctl.

sreejithpunnapuzha avatar sreejithpunnapuzha commented on August 11, 2024

All yours @sirajyasin

from airshipctl.

sirajyasin avatar sirajyasin commented on August 11, 2024

This Issue can be marked completed/Closed. Both the related PSs are merged now.

from airshipctl.

eak13 avatar eak13 commented on August 11, 2024

closing per merge

from airshipctl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.