GithubHelp home page GithubHelp logo

Comments (6)

ajkerr0 avatar ajkerr0 commented on August 18, 2024

I think I've figured out that the nextIndexI code in operation.chain doesn't consider cases where the nextIndexI is part of the current molecule1 and not molecule2.

from kappa.

ajkerr0 avatar ajkerr0 commented on August 18, 2024

What's happening is chain is used assuming that the next molecule is being attached to molecule2 of the last attachment.

from kappa.

ajkerr0 avatar ajkerr0 commented on August 18, 2024

Maybe we should resort to using _combine for non-successive attachments? But I like the idea of forcing a Molecule.configure call when the process is completed. [.configure is] Totally wasteful in a multi-attachment process and takes a considerable amount of time with this large molecules like CNTs.

from kappa.

ajkerr0 avatar ajkerr0 commented on August 18, 2024

I could keep chain but switch between the use of nextIndexI with the use of a keyword argument that defaults to not using it? Ultimately a question of design I think.

Maybe _configure should only be called when it is explicitly needed, or make the user call it when needed and want access to those generated attributes. define_energy/gradient_routine is (atm) supposed to be called when needed (like preceeding energy minimization).

from kappa.

ajkerr0 avatar ajkerr0 commented on August 18, 2024

I could do something where if the inputted indices are negative, then attach them to molecule1. But that would require the user to know this. It may be more straightforward, however more cluttered, to use a keyword argument that defaults to to something.

from kappa.

ajkerr0 avatar ajkerr0 commented on August 18, 2024

Going to close the issue. Documentation should reflect this specific use of .chain now. It was more important to be aware of the function, it was not actually an issue with the code.

from kappa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.