Comments (5)
Yeah, template ref is a bit broken at the moment. I don't think looking at
the template contents owner will work, though, since none of the elements
are in the Document (and thus none of them actually have IDs, even if they
have an "id" attribute). The whole feature might need some rethinking given
the Template spec.
On Mon, Jan 7, 2013 at 11:01 AM, Erik Arvidsson [email protected]:
In HTMLTemplateElement.cpp near line 214:
Element* element =
m_template->treeScope()->getElementById(m_template->fastGetAttribute(refAttr));This does not work correctly since we might need to check both the
ownerDocument of the template element as well as the template contents ownerMaybe an example will show what I mean.
...
...
...
...Also see
https://code.google.com/p/mdv/source/browse/template_element.js#510—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20.
from webkit.
You are right. I wonder how the polyfill ever worked?
from webkit.
The polyfill had all templates in the same document and users of the
polyfill just needed to avoid doing anything that depended upon inertness
(the only trick was making templates display:none).
On Mon, Jan 7, 2013 at 1:38 PM, Erik Arvidsson [email protected]:
You are right. I wonder how the polyfill ever worked?
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-11973019.
from webkit.
On Mon, Jan 7, 2013 at 4:41 PM, Adam Klein [email protected] wrote:
The polyfill had all templates in the same document and users of the
polyfill just needed to avoid doing anything that depended upon inertness
(the only trick was making templates display:none).
No, it worked after I moved stuff into .content too.
erik
from webkit.
I think the original idea of the feature was that ref would refer to elements in the top-level document (the one with a frame) only.
The branch could walk up the host-chain to make sure it was doing getElementById on that document. The shim can probably know by way of its top-down processing.
from webkit.
Related Issues (19)
- Implement DOM stability for iteration
- design formal delegate API
- need the ability to reference "this" and ancestor values within bindings HOT 1
- non-string model values cause crashes in v8::Value::toString HOT 1
- Avoid memory leaks by holding the .model and .modelDelegate properties in the JS wrapper
- Provide an API on Element and Text to get a list of bindings HOT 5
- Add synchronous API to HTMLTemplateElement for template instantiation HOT 1
- added .model and .modelDelegate to ShadowRoot HOT 1
- Error in Source/WebCore/mdv/ScriptValueBinding.cpp HOT 1
- Wrong check for text binding
- re-hookup innerHTML for HTMLTemplateElement HOT 2
- Attempt to implement better cloneNode(true) behavior for templates
- removing a template element should cause its instances to be removed HOT 2
- design how model values propagate into shadow dom HOT 3
- implement <template instantiate/iterate ref> HOT 1
- need tests asserting that parser-created templates function properly HOT 1
- design context-aware bindings HOT 1
- design a safe mechanism for binding markup into a "hole" in a template. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webkit.