if/then false positive when if-property is undefined. about ajv

[LazerJesus]

Reproduction:

import Ajv from "ajv";

const ajv = new Ajv({ allErrors: false, verbose: true, $data: true });

const annotationschema = {
    type: "object",
    properties: {
        pos: {type: "string"},
        lemma: {type: "string"},
        verbform: {type: "string", enum: ["fin", "inf"]},
        tense: {type: "string"},
        gender: {type: "string"}
    },
    required: ["pos", "lemma", "verbform"],
    allOf: [
        {
            if: {properties: {verbform: {const: "fin"}}},
            then: {required: ["tense"], properties: {gender: {not: {}}}}
        }
    ]
};

const annotation = {
    pos: "verb",
    lemma: "something"
    // verbform: "inf" // toggle this to see the error magically disappear, even tho the if condition is just as false.
};

const validate = ajv.compile(annotationschema);
const valid = validate(annotation);
console.log(valid);
console.log(validate.errors);

[jasoniangreen]

Hi @LazerJesus, thanks for brining this to our attention. After playing around with your example for a bit it does indeed look like a bug to me. I can even pass an empty object and it still complains about missing tense. I will look into it.

[epoberezkin]

schema in "if" says that when verbForm is present it should be "fin" but it doesn't require that it's present.

So in the absense of verbForm the schema in "if" passes validation, and schema in "then" is applied.

meaning that the if: { properties: { verbform: { const: "fin" } } } is somehow true for { pos: 'verb' } ?!

That's exactly how JSON schema spec is supposed to work 🤷‍♂️

If you make this property required, it will be "false", but it's not implied.

[jasoniangreen]

Ah yes of course, I was thrown by the fact that the outer schema has "verbform" in the required array, but the if schema is treated separately so will need it's own required.

        {
            if: {
                properties: {verbform: {const: "fin"}},
                required: ["verbform"],
            },
            then: {required: ["tense"]},
        }

[LazerJesus]

Indeed that solves it. thank you for the information.

i must say tho, that its very counterintuitive and seems to conflict with logic.
since the statementif: { properties: { verbform: { const: "fin" } } } is true, the logical branch to execute is then.
adding the qualifier required doesnt, for me, change the proposition.
the verbform either is, or is not fin.

that being said, ill just add the qualifier and thats that ✌️ all the best