GithubHelp home page GithubHelp logo

Comments (3)

tombeynon avatar tombeynon commented on August 15, 2024 1

We can definitely pull more runtime config from chain.json, does it make sense to use fixed_min_gas_price if available for the minimum_gas_price? Would be great to automate that particular config since Osmosis will require it soon.

Buiild time config is something I've thought about making entirely dynamic from chain.json but I think it breaks the Docker convention of repeatable builds - it would be very easy for a chain to be accidentally upgraded/downgraded when a new version of Omnibus is released for example. I was thinking a Makefile/CLI tool for Omnibus might be a good idea though - it could automate the addition/update of chains using a chain.json, which would update the build.yml files with the correct version, binary URL etc.

I'd love to get to a place where changes to the Chain Registry can automatically trigger updates in Omnibus, probably with a PR review in the middle.

from cosmos-omnibus.

boz avatar boz commented on August 15, 2024

We can start optionally using chain.json at build time to set defaults, not a bad idea.

You can use chain.json for configuration at runtime - but it doesn't look like we're pulling gas prices at the moment. Runtime configuration can also be set manually via environment variables or flags.

from cosmos-omnibus.

tombeynon avatar tombeynon commented on August 15, 2024

Fixed in #154 and #162

from cosmos-omnibus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.