2.1.2 Compatibility about redmine_banner

[jm66]

Yup, It's very broken. Do you have an estimate of when this plugin will be available for Redmine 2.1.2? Thanks!

[akiko-pusu]

Thank you for your feedback!
And sorry for my late reply...

Now I'm try to porting for Redmine2.1.x. and pushed modified code on dev branch.
(https://github.com/akiko-pusu/redmine_banner/tree/dev)

Here is my output of "rake about" command. (Redmine2.1.3)

$ rake about
About your application's environment
Ruby version 1.9.2 (x86_64-darwin12.2.1)
RubyGems version 1.8.23
Rack version 1.4
Rails version 3.2.8
Active Record version 3.2.8
Action Pack version 3.2.8
Active Resource version 3.2.8
Action Mailer version 3.2.8
Active Support version 3.2.8
Middleware ActionDispatch::Static, Rack::Lock, #ActiveSupport::Cache::Strategy::LocalCache::Middleware:0x007f889b756a90, Rack::Runtime, Rack::MethodOverride, ActionDispatch::RequestId, Rails::Rack::Logger, ActionDispatch::ShowExceptions, ActionDispatch::DebugExceptions, ActionDispatch::RemoteIp, ActionDispatch::Reloader, ActionDispatch::Callbacks, ActiveRecord::ConnectionAdapters::ConnectionManagement, ActiveRecord::QueryCache, ActionDispatch::Cookies, ActionDispatch::Session::CookieStore, ActionDispatch::Flash, ActionDispatch::ParamsParser, ActionDispatch::Head, Rack::ConditionalGet, Rack::ETag, ActionDispatch::BestStandardsSupport, OpenIdAuthentication
Application root /Users/***/work/redmine
Environment development
Database adapter sqlite3
Database schema version 20120731164049

Maybe I have to run some tests and try to run with ruy1.9.3.
If you don't mind, please try dev branch and give me some feedback.

[akiko-pusu]

Now mastar branch support Redmine2.1.2. Please try and give me some feedback.

[atopcu]

Thank You akiko-pusu,
I have tried in our 2.1.2 and it works very well...
I dont need, but I have tried it in project. But, I can't use it inside of project. module enabled but there is no Banner tab in project settings.

Regards..

[jm66]

Thanks a lot! It's working perfectly on Redmine 2.1.2.stable.10669. Great work.

[akiko-pusu]

Could you please check if the role of project admin has Manage Banner Permission to show Project Banner Settings tab. This is mentioned on Readme.rdoc.

[jm66]

Yes, I've already tried it and is working perfectly as well.

[manish5377]

No Banner tab in project settings. Module is enabled and permission to manage banner is granted.
Using 2.1.4.stable on Linux with Fire Fox

[akiko-pusu]

Hello, manish5377.
Thank you for your feedback.

Could yoy please let me know if the html for "Banner Tab" is shown or not on project settings page.

1. Go to some project page.
2. Click project settings tab.
3. You ca see "Information" tab at the left side.
4. Then, please view html source of this page.
5. Please search "Banner".

If the banner plugin is activete corectly, you can find the statement for banner tab like this:

• .....
• Banner

If there is no html for banner tab, I have to fix it.
And If you find Banner tab html but it does not exist via browser, I think this is due to some style definition.

[atopcu]

Dear Akkiko-pusu,
There is no Banner tab in HTML code also.
Thanks again.
Regards,

[akiko-pusu]

Thank you for your additional information.
Could you please let me know your redmine version and plugins information?

You can find these information at Administration -> Information page.
(Such as http://localhost:3000/admin/info)

Exp. Mine is this:

Environment:
Redmine version 2.1.4.stable
Ruby version 1.9.3 (x86_64-darwin12.2.1)
Rails version 3.2.8
Environment production
Database adapter SQLite
Redmine plugins:
redmine_banner 0.0.8
redmine_issue_templates 0.0.4

[atopcu]

Of Course akiko-pusu,

Environment:
Redmine version 2.1.4.stable
Ruby version 1.8.7 (x86_64-linux)
Rails version 3.2.8
Environment production
Database adapter MySQL

Redmine plugins:
due_date_reminder 0.3.2
extended_fields 0.2.0b
redmine_assets_plugin 0.0.1
redmine_banner 0.0.8
redmine_boards_watchers 0.2.5
redmine_changeauthor 1.0.0
redmine_contacts 3.0.1-pro
redmine_contacts_helpdesk 2.0.1
redmine_favourite_projects 0.6
redmine_information 1.0.2
redmine_inline_attach_screenshot 0.4.2
redmine_issue_checklist 2.0.0
redmine_ldap_sync 1.3.0
redmine_logs 0.0.5
redmine_meetings 0.2.3
redmine_milestones 1.0.0-pro-alpha1
redmine_monitoring_controlling 0.1.1
redmine_private_wiki 0.2.2
redmine_release_notes 1.2.0
redmine_reorder_links_arbitrary 0.0.7
redmine_smart_issues_sort 0.3.1
redmine_stealth 0.6.0
redmine_textilizable_custom_fields 0.0.1
redmine_theme_changer 0.1.0
redmine_wiki_extensions 0.6.0
redmine_wiki_toc 0.0.4
redmine_wktime 1.1
redmine_work_time 0.2.6

[akiko-pusu]

Thank you for your prompt reply. This is very helpful for me. Please wail for a while!

[atopcu]

Thanks.
Sent by BlackBerry Internet Service from Turkcell

-----Original Message-----
From: Akiko Takano [email protected]
Date: Mon, 03 Dec 2012 14:15:26
To: akiko-pusu/[email protected]
Reply-To: akiko-pusu/redmine_banner [email protected]
Cc: [email protected]
Subject: Re: [redmine_banner] 2.1.2 Compatibility (#24)

Thank you for your prompt reply. This is very helpful for me. Please wail for a while!

---

Reply to this email directly or view it on GitHub:
#24 (comment)

[akiko-pusu]

Hi, atopcu.

My guess is this is because some plugin override project setting tabs.
Are there any other plugins which are shown at project settings tabs?
(Maybe redmine_contacts, or redmine_milestones)

[atopcu]

Hi akiko-pusu,
sorry for late response,
I have tried to disable all other 3rd plugins in project except "banner", but project setting tab for the banner still does not exist.

Best Regards,

[akiko-pusu]

Thank you so much for your trial and repotying. So I'm going to set up the same env for you.(Ruby1.8x, Redmine2.1.4).

[akiko-pusu]

Hi atopcu,
I've tried on Redmin2.1.4-stable and Ruby1.8x but I could not reproduce the problem.
Sorry, nothing can be done about this problem....
(I did run redmine with only redmine_banner plugin. There is no plugins under REDMINE_ROOT/plugins directory except mine. )

If this feature works correctly, you can see the banner tab on project settings.
Here is the screenshot.

• https://github.com/akiko-pusu/wiki_images/blob/master/project-banner-setting.png

[atopcu]

Hi akiko-pusu,
Okay, I think you are right. My case may be related to other plugins.

Thanks for your effort and support.
Best Regards,

[cforce]

Here it works smooth also

[manish5377]

Though this is closed. I think it might be related to redmine_milestone plugin. For some reason i did not install milestone on another environment and banner worked fine.

[akiko-pusu]

Thank you everyone!

SInce I'm interested in redmine_milstones plugin, clone it from https://github.com/k41n/redmine_milestones.
After that, I checked out the branche named redmine-2.x, for Redmine2.x.

I think this is the one that atopcu is using.

Then, I installed and migrate this plugin, I could finally reproduce the same problem.

---

This is because redmine_milstones re-define project setting tabs in lib/projects_helper_patch.rb.

It seems plugins are loaded in alphabetical order, so that banner plugin is loaded n an early stage.
Banner plugins add a tab for itself, but after that, redmine_milstones re-defines the tabs.
If my plugins name was different, such as "redmine_widely_banner", and loaded after redmine_milstones, this problems won't happen ;-)

Indeed, some plugins that I know well, such as wiki extensions, works fine about project settings tab.

Anyway, I hope to some feedback to the author of redmine_milestones. Maybe using alias method chain is effective to avoid overwriting.

Any comment or objection will be appreciated.

[atopcu]

You are unbelievable. :)