customPaging about react-slick

[akiran]

Yes, I will try to implement it this weekend.

or If possible, can you try to implement and submit a pull request

[flowdee]

Thanks for your quick reply @akiran . Would be awesome if you implement this as soon as possible!

[akiran]

ok

[flowdee]

Any updates here @akiran ? Did you find time to test the implementation yet?

[rockymadden]

@flowdee and @akiran, see #36

[flowdee]

thanks

[akiran]

@rockymadden Thanks for the pull request.
I will review it and merge soon

[dra1n]

customPaging function in default-props is barely usable. It has signature function(onClick, i, element), but in Dots component there is call this.props.customPaging(i). As a result we have <button>NaN</button> and a lot of noise from React complaining about props.children mutation because NaN != NaN

customPaging: (i) => <button>{i + 1}</button> Fixes this issue

[akiran]

customPaging implementation is still under review.
Even I am not fully confident about the current implementation. Hence not published it yet.

Welcome PR's and suggestions

[akiran]

@dra1n Fixed the customPaging default prop issue.

[dra1n]

Hello! Strange things I have version "0.14.3" and customPaging is already
implemented and works almost fine.

But to the point. Function in default-props still uses onClick var which is
undefined now. This won't cause an error only because onClick will be
overridden when we are creating dot element in dots.jsx {React.cloneElement(
this.props.customPaging(i), {onClick})} So it would be better to leave
default button like this {i + 1}

Sorry for being lazy and not sending PR on this.

2016-09-16 14:24 GMT+03:00 Kiran [email protected]:

@dra1n https://github.com/dra1n Fixed the customPaging default prop
issue.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAS5Wdo-tP3MUc-_1LxkS2QhoXHnruCaks5qqnxbgaJpZM4DirJ5
.

[akiran]

Fixed it in 0.14.4