Two instances of ToastyService when lazy loading routes and shared module about ng2-toasty

[thewax]

Sorry to write on a closed issue, but is there any way to make this work without the core module pattern? Right now it's spawning a new service for each module.

[akserg]

Hi @tomasisby
I didn't test it in lazy loading environment. Thanks for prompt.

[tomasisby]

Hello!
I've meddled around with Angular core.module and found a way to make this work. You need to export the ToastyModule in shared.module and ToastyService in core.module, like this:

In shared.module:

import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { FormsModule } from '@angular/forms';
import { ToastyModule } from 'ng2-toasty';

@NgModule({
imports: [
CommonModule,
ToastyModule
],
declarations: [],
exports: [
CommonModule,
FormsModule,
ToastyModule
]
})
export class SharedModule {}

And in core.module you take care of the services:

import { NgModule, Optional, SkipSelf } from '@angular/core';
import { CommonModule } from '@angular/common';
import { ToastyService, ToastyConfig } from 'ng2-toasty';

@NgModule({
imports: [
CommonModule
],
declarations: [],
exports: [],
providers: [
ToastyService,
ToastyConfig,
]
})
export class CoreModule {
constructor( @optional() @SkipSelf() parentModule: CoreModule) {
if (parentModule) {
throw new Error('CoreModule is already loaded. Import it in the AppModule only');
}
}
}

And then in app.module you import both shared.module and core.module so you can get a singleton service for the root application:

import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { AppComponent } from './app.component';
import { SharedModule } from './shared.module';
import { CoreModule } from './core/core.module';
import { routing } from './app.routing';
@NgModule({
imports: [
BrowserModule,
SharedModule,
CoreModule,
routing
],
declarations: [
AppComponent
],
bootstrap: [AppComponent]
})
export class AppModule { }

And voila! It works as expected with only one instance of toasty service for lazy loaded routes as well.

[akserg]

Impressive.
Thanks for time and sharing code.