GithubHelp home page GithubHelp logo

Fix highlight package about flutter-code-editor HOT 2 OPEN

akvelon avatar akvelon commented on July 28, 2024
Fix highlight package

from flutter-code-editor.

Comments (2)

alexeyinkin avatar alexeyinkin commented on July 28, 2024

We are using this package for highlighting: https://pub.dev/packages/highlight
It is not maintained, and the authors do not respond to issues.

It is a port of a well-maintained JavaScript package: https://highlightjs.org

Maybe we should investigate the automation of porting this from JavaScript and make our own highlighting package.

from flutter-code-editor.

alexeyinkin avatar alexeyinkin commented on July 28, 2024

The impact is that we rely on to-be-hidden service comments for special features like read-only blocks, initially collapsed blocks, and hidden blocks. And we rely on this highlighting package to parse the comments. If some code breaks highlighting, we cannot parse comments, and those features break.

A workaround is made in #28. If highlighting breaks, we fall back to a naive parsing that just searches for // or # depending on the language and considers everything from that sequence to the end of the string a comment. It gives false positives for

string s = "// not a comment";

and so it is unreliable.

from flutter-code-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.