alanrenouf / vcheck-vsphere Goto Github PK

View Code? Open in Web Editor NEW

733.0 733.0 325.0 1.6 MB

vCheck Daily Report for vSphere

License: MIT License

PowerShell 100.00%

vcheck-vsphere's People

Contributors

Stargazers

Watchers

Forkers

jonathanmedd kmruddy cscoltock djgauthier bobert13581 danielhatke rgoodworth jakerobinson jmercier-ndp bin0uz3 sarreshteh craigawsmith sammcgeown miguel8lopez jamessantiago jones-g pauljordan juliog rupeshpednekar semmal coterl sosher holala scottmckenzie widsinga vlucaswang brad4bush bgarlock alpacacode fultonop doctorcomputer bulletprooffool dcdelapaz georgios-koukoulieros frogeater everest90909 sneddo gibsonj dwalcoff samliu79 parodymshifter lamw foam689 kdmhorn lturkin steamnah stufl dennietidwell joelg17 theweave zsoldier delouwere medikdave jojo1303 philrandal tmitchell5280 jaggedstream tyal wap207 winga varutla tcxrk0 mj5kqt8rjthtg9nyxysf sybux-zz rvdnieuwendijk tquizzle parambil agreatround akarthikeyan16 moreandres notevenahint57 emanuelemazza othercwood swerveshot paulobartos tommy13v ghamed kizz1337 markliam10 paulwalkeruk feehoo daigohji bchizum brekus mirzawaqasahmed kandadeepak tlhutch nicolabressan bluraydisk arockiaantony bane58 skeetneet darkgreising masterchiefjon haripetrov dagnu46 johntraskcgi techgecko roofuzz danimalrowe

vcheck-vsphere's Issues

Suggestion: Tag releases

Just a thought, since there have been a number of release lately it may be worth starting to tag releases:
http://git-scm.com/book/en/Git-Basics-Tagging

This could then replace the changelog.txt file that gets forgotten about occasionally, and gives us more of an idea what has changes between versions.

vCheck default answers (first run)

when running vCheck for the first time, some of the default values have a space before, or after, or both.

This is not a problem for integer, but for strings the match or notmatch operators don't work.

Example : I use the default value provided for 62 Unwanted Virtual Hardware which is [ VirtualUSBController|VirtualParallelPort|VirtualSerialPort]

so the generated var $unwantedHadware in the script is " VirtualUSBController|VirtualParallelPort|VirtualSerialPort" instead of "VirtualUSBController|VirtualParallelPort|VirtualSerialPort"

and then the script reports nothing because of the match operator not matching.

Default values provided during first run should be [something](not [ something] or [ something ]).

Merge Plugin reports into vCheck.ps1

Adding as an enhancement until someone has time to look at it- if there is benefit to it?

I feel like the functionality of the following plugins should be merged into the main vCheck script:
Plugins Not up to date or installed.ps1
Report on Plugins.ps1

We could then have a GlobalVariables.ps1 entry to determine if they are appended to the report.

This would mean that if these plugins are updated, there is no need to update across all vCheck projects. This also means that plugins in the plugins directory only refer to information about that particular environment (i.e. vSphere/Exchange/etc), whereas these plugins refer more to the vCheck environment.

If these plugins are to be useful, the plugins.xml also needs to be updated when plugins are updated or added:
http://www.virtu-al.net/vcheck/plugins/plugins.xml

What do you think?

Suggestion - Ordering Plugins

I'm sure this has been thought about before but...wouldn't it be nice to have some sort of organization to the plugins?

I'm not sure of the best way to do this, maybe a numbering scheme that would group similar plugins?
For Example:
100-199 - All vCenter related plugins
200-299 - All Host related plugins
300-399 - All Cluster related plugins
400-499 - All VM related plugins
etc

Far from perfect but would at least keep the major categories together.

A more drastic approach may be to add a category/group to each plugin defining the output order.

Thoughts?

Hardware status warnings/errors

We have moved to vCentre 5.1 and upgraded our HOST from 4.1 to ESXi5.1. We moved our vCheck as well. The issue we are having is under Hardware status warnings/errors we are seeing alerts status (Yellow) but in vCentre under Hardware Status the sensors are all normal

22 Checking VM Hardware Version: problem with v10 (ESXi 5.5)

VMs with hardware version 10 return 0 and so are listed if we set to check vms prior to hardware version 10.

51 syslog name.ps1

Unexpected Token "isnotnullempty" in expression or statement
51 Syslog Name.ps1: line13 character:256

@($VMH | Where-Object {$.ExtensionData.Summary.Config.Product.Name -eq 'VMware ESXi'} | Select-Object Name,@{Name='SyslogSetting';Expression = {(Get-VMHostAdvancedConfiguration -VMHost $ -Name Syslog.Local.DatastorePath).Values| Where {$_ isnotnullempty <<<< }}})
- CategoryInfo : ParserError: (isnotnullempty:String) [], ParseException
- FullyQualifiedErrorId : UnexpectedToken

63 & 65 - Snapshot User Exception

I need to provide multiple users in which these scripts will not check for snapshots for users listed.

Is this how it should be formatted?

$snapshotUserException = "s-veeam, domain\username"

or should we modify the get-view statement to take multiple variables?

$snapshotUserException1 = "s-veeam"
$snapshotUserException2 = "domain\username"

    (($_.userName -notmatch $snapshotUserException1) -or ($_.userName -notmatch $snapshotUserException2))

52 (Datastore Consistency) only displays last cluster

Running this script on a vcenter with several clusters, only the last cluster collected by Get-Cluster is displayed in report.

I think $problemDatastores is erased each time a cluster is processed by foreach iteration, then only the last cluster is kept.

52 Datastore Consistency.ps1

I got this error when i ran the main script

Unexpected token '.5' in expression or statement.
At c:\vCheck-vSphere-master\Plugins\52 Datastore Consistency.ps1:30 char:23

$PluginVersion = 1.2.5 <<<<
- CategoryInfo : ParserError: (.5:String) [], ParseException
- FullyQualifiedErrorId : UnexpectedToken

Push style variables to style from GlobalVariables.ps1

Just adding these as possible enhancements, if someone has time to look at them. Otherwise I'll get to them at some point...

We should be aiming on moving all style-related variables to the style files. This will require less configuration on first run, and greater separation of script logic and markup.

Remove style variables from GlobalVariables.ps1 and push to style .ps1 files:
$Colour1
$Colour2
$TitleTxtColour

Should also remove the "00 1st Plugin - Select Report Header Image.ps1" file and incorporate this into style files. We can also remove the Headers directory and all headers it contains (or move them to "default" style).

Enhancement: Formatting rules for tables

Something that I found useful in our environment, posting here to see if there is any value in merging to vCheck.

The basic idea is that the vCheck.ps1 has been extended to allow table formatting rules to be passed along to it. These rules are defined in the plugin (see 03 Datastore Information.ps1 for example). Formatting can be applied to Cells, Rows, or Columns.

Can be grabbed from here (only datastores report has been modified at this stage)
https://github.com/Sneddo/vCheck-vSphere

It may not be as easy to use as possible (i.e. perhaps this could be defined in a similar fashion to settings?), but the basic idea is there.

Filter request for 27,66 and 100

Not sure if this is correct way of asking for an enhancement, but..
We use Zerto as a DR replication tool and the helper VM's always clutter the vCheck report. Would it be possible to add a VM name filter to plugins 27, 66 and 100?
These are the plugins for VM Tools Issues, Misnamed VM's and VM's with CPU and Memory Reservations.
Please point me in the right direction if this is not the correct forum.

RuntimeException - vCheck.ps1

I am currently testing with only two plugins:

00 Connection Plugin for vCenter.ps1
999 VeryLastPlugin Used to Disconnect.ps1

I am getting the following message with latest version of vCheck:

You cannot call a method on a null-valued expression.
At ... vCheck.ps1:289 char:25

                    $type = $path.substring($path.LastIndexOf(".")+1)

```
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
- CategoryInfo : InvalidOperation: (:) [], RuntimeException
- FullyQualifiedErrorId : InvokeMethodOnNull

45 VMs needing snapshot consolidation Exceptions

I keep getting these errors -- quite a few of them. Here are some examples:

2:48:59 PM .. start calculating VMs needing snapshot consolidation by Luc Dekens, Frederic Martin v1.2
Exception calling "Add" with "2" argument(s): "Item has already been added. Key in dictionary: 'HostSystem-host-116' Key being
added: 'HostSystem-host-116'"
At C:\Users\xxx\Downloads\vCheck-vSphere-master (1)\vCheck-vSphere-master\Plugins\45 VMs needing snapshot
consolidation.ps1:5 char:17

$HostsViews | %{$htabHostVersion.Add($.MoRef,$.config.product.version)}
```
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
- CategoryInfo : NotSpecified: (:) [], MethodInvocationException
- FullyQualifiedErrorId : ArgumentException

Exception calling "Add" with "2" argument(s): "Item has already been added. Key in dictionary: 'HostSystem-host-1648' Key being
added: 'HostSystem-host-1648'"
At C:\Users\xxx\Downloads\vCheck-vSphere-master (1)\vCheck-vSphere-master\Plugins\45 VMs needing snapshot
consolidation.ps1:5 char:17

$HostsViews | %{$htabHostVersion.Add($.MoRef,$.config.product.version)}
```
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
- CategoryInfo : NotSpecified: (:) [], MethodInvocationException
- FullyQualifiedErrorId : ArgumentException

Exception calling "Add" with "2" argument(s): "Item has already been added. Key in dictionary: 'HostSystem-host-1700' Key being
added: 'HostSystem-host-1700'"
At C:\Users\xxx\Downloads\vCheck-vSphere-master (1)\vCheck-vSphere-master\Plugins\45 VMs needing snapshot
consolidation.ps1:5 char:17

$HostsViews | %{$htabHostVersion.Add($.MoRef,$.config.product.version)}
```
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
- CategoryInfo : NotSpecified: (:) [], MethodInvocationException
- FullyQualifiedErrorId : ArgumentException

Plugins/80 DvPG with less than x Ports Free.ps1 failure

The term 'Get-VDSwitch' is not recognized as the name of a cmdlet, function, script file, or operable program.

The term 'Get-VDPortgroup' is not recognized as the name of a cmdlet, function, script file, or operable program.

Add table of contents and nav links to reports

Just flagging this as a "Todo" item...

On long reports it can be a bit tedious navigating. I'm suggesting we include a table of contents (enabled by global variable), and have "back to top" links for each plugin to allow quick navigation.

This could possibly be expanded in future releases to include a summary section. e.g. instead of just linking to the plugin section by name "Datastore Information", link using the Plugin title "Datastores (Less than 25% Free) : 118". This will require a bit more work and changes to style handling.

vCheck error

I get some errors when running vCheck.ps1, installed it today from GIT so latest version.

....
15:46:35 ..finished calculating Datastores with Storage IO Control Disabled by Robert van den Nieuwendijk v1,1
15:46:35 ..finished calculating VMs by Operating System by Raymond v1,1
15:46:35 ..finished calculating Unwanted virtual hardware found by Frederic Martin v1,1
Cannot convert argument "_this", with value: "VimApi_50.ManagedObjectReference", for "SearchDatastoreSubFolders_Task" t
o type "VimApi_51.ManagedObjectReference": "Cannot convert the "VimApi_50.ManagedObjectReference" value of type "VimApi
_50.ManagedObjectReference" to type "VimApi_51.ManagedObjectReference"."
At C:\temp\vCheck-vSphere-master\Plugins\64 Snapshots Oversize.ps1:44 char:4

        $taskMoRef  = $dsb.Client.VimService.SearchDatastoreSubFolders_Task($dsBrowse ...

CategoryInfo : NotSpecified: (:) [], MethodException
FullyQualifiedErrorId : MethodArgumentConversionInvalidCastArgument