FindById and job identifiers/human names about jobs

[albrow]

@utrack I'm not sure I understand. Can you elaborate on what you mean by "readable name"?

[utrack]

@albrow well uh, term "job type identifiers" is a better term : )

Here's what i mean:

welcomeEmailJobs, err := jobs.RegisterType("welcomeEmail", 3, func(user *User) error {
   // here be dragons
})

// spam poor guy
job, err := welcomeEmailJobs.ScheduleRecurring(100, time.Now(),time.Second*60, &User{EmailAddress: "[email protected]"})
if err != nil {
    // Handle err
}

... somewhere else
tasks,err := jobs.FindById("welcomeEmail") // it doesn't work but nice to have
// -- tasks would contain job from previous snippet or at least unique string identifiers, which can be used to retrieve scheduled tasks by current FindById()

The problem I experience is: there's recurring task that gets registered each time app is started; as they can't be cleaned up in every possible case (say, power failure for app's node) the scheduled tasks pile up.

[albrow]

Okay I think I understand now. What you want to do is get all jobs of a particular Type? I don't like the idea of saying that FindById takes a job id or a job type as an argument. It's conflating two different things.

What I would rather do is add a new method on Type. Something like FindAll. Continuing from your example, you could run something like:

tasks,err := welcomEmailJobs.FindAll()
for _, task := range tasks {
    // Do what you want with each task.
}

Does that cover your use case?

[utrack]

Yup, that's even better :)

[umayr]

Is there any update on this one? @albrow

[albrow]

@umayr sorry for going dark on this one.

I have many projects to maintain and moving forward I'm going to focus on bug fixes and maintenance. I will not be adding any new features to Jobs in the near future, but I would be happy to review PRs. I have also been speaking with a few developers to try and find additional maintainers.

I will update the Development Status section of the README to reflect this.