Allow passing options to the REST server about backbone-offline

[alekseykulikov]

Obviously I use collection.fetch({data: {username: myusername, password: mypassword}});
But I never used fetch with params and backbone.offline together, probably, there's can be some mistake.

[rjmackay]

I've worked around this issue by overriding methods for now:

Offline.syncWithAuth = function(method, model, options, error) {
    var settings = model.settings || model.collection.settings;

    // Add username / password
    if (!options.username)
    {
        options.username = settings.get('username');
        options.password = settings.get('password');
    }

    Backbone.ajaxSync.apply(this, [method, model, options, error]);
};

// Override offline sync to use syncwithAuth
Offline.sync = function(method, model, options) {
    var store, _ref;
    store = model.storage || ((_ref = model.collection) != null ? _ref.storage : void 0);
    if (store && (store != null ? store.support : void 0)) {
        return Offline.localSync(method, model, options, store);
    } else {
        return Offline.syncWithAuth(method, model, options);
    }
};

// Tweak the Backbone.offline ajax sync
Offline.Sync.prototype.ajax = function(method, model, options) {
    if (Offline.onLine()) {
        this.prepareOptions(options);

        var settings = model.settings || model.collection.settings;

        // add username / password
        if (!options.username)
        {
            options.username = settings.get('username');
            options.password = settings.get('password');
        }

        return Backbone.ajaxSync(method, model, options);
    } else {
        return this.storage.setItem('offline', 'true');
    }
};

[alekseykulikov]

@rjmackay It looks like a good patch for your local goals, thanks for your experience. Maybe I should add a shared way for adding additional parameters to backbone.offline. What do you think about it?

[rjmackay]

My solution works when you're always passing the same parameters. However
with standard ajaxSync parameters passed to fetch() would be forwarded to
jquery.ajax()
It would be good to preserve this behaviour, ie: if offline ignore the
fetch params, if online pass them as with normal ajax sync.

On Tue, May 22, 2012 at 6:27 PM, Aleksey Kulikov <
[email protected]

wrote:

@rjmackay It looks like a good patch for your local goals, thanks for your
experience. Maybe I should add a shared way for adding additional
parameters to backbone.offline. What do you think about it?

---

Reply to this email directly or view it on GitHub:
#8 (comment)