Comments (4)
@ghostant-1017 Happy to re-evaluate the report security, lets correspond in HackerOne regarding that.
In the meantime, we have another addition to this fix in the form of https://github.com/AleoHQ/snarkOS/pull/3233 that addresses an edge case. Would love you have your review of this as well.
from snarkos.
This PR should address the issue - https://github.com/AleoHQ/snarkOS/pull/3232.
The finding was related to another issue we were observing in devnet, but this change should address both concerns.
@ghostant-1017 Please confirm if you believe this fix is sufficient!
from snarkos.
Hi @raychu86 ,
The attack doesn't work only for validators which is syncing. In fact, it works for ALL SYNCED validators.
The attacker will always generate block which height is latest_height + 1
, so that other validators will find themselves are behind, and send BlockRequest to the attacker.
Please reevaluate the severity of the report. Thank you!
from snarkos.
Closing with https://github.com/AleoHQ/snarkOS/pull/3232
from snarkos.
Related Issues (20)
- [Bug] testnet-beta clients takes minutes to connect HOT 1
- [Bug] Malicious validators can launch DDoS attacks by constructing and broadcasting fake solutions, severely harming network performance HOT 3
- [Bug] Sync status incorrectly reported HOT 3
- [Bug] Malicious peers can still send spam connection attempts HOT 9
- Safe validator initial start HOT 1
- [Bug] Malicious validator can send fake BlockResponse to block honest validators from processing messages HOT 5
- Do not log for actions against validators or delegators that are not active. HOT 2
- [Bug] Block synchronization has race condition HOT 5
- [Bug] Malicious node do not send BlockResponse, making it difficult for honest node to complete synchronization HOT 1
- [Bug] Potential temporary sync stall from weak-link or malicious peers HOT 1
- [Proposal] The bft module's gateway should check block request and block response from peers to avoid spam HOT 3
- [Bug] Memory leak in seen_outbound_block_requests
- [Bug] Abnormal disconnection caused by asynchronous Ping message HOT 5
- [Bug]git checkout tags/testnet-beta HEAD is now at 878624d6c Merge pull request #3329 from ProvableHQ/fix/snarkvm-history-rev HOT 1
- [Feature] Enable automated fetching of peer nodes from a bootstrap node and direct connection setup in snarkOS. HOT 1
- [Proposal] Feature Request: support custom IP in param HOT 1
- [Bug] snarkos_node_router::heartbeat: No connected peers HOT 6
- [Bug] OOM kill because sudden memory increase and requests HOT 4
- [Bug]Skipping an iteration of the puzzle (no connected peers) DEBUG snarkos_node_router::handshake: Connecting to 34.168.118.156:4130... 2024-07-03T02:16:36.575195Z WARN snarkos_node_router: Unable to connect to '34.168.118.156:4130' - '34.168.118.156:4130' disconnected before sending "Message::ChallengeResponse" HOT 2
- [Feature] Improvement: don't pull in all features when adding snarkVM dependency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from snarkos.