Question: How/why is this package useful? about sweetalert2-react

[hipstersmoothie]

I'd expect most everything that is related to the dom to be expressed through jsx.

If another developer were to come into my project with SweetAlert as just a function, it might be confusing finding the one place in my app where dom isn't expressed through jsx in a render function. Since this repo makes it a component I can keep all my jsx inside my render function and the outside developer wouldn't have to learn about a new api that defines jsx in an onclick callback. They would just look to the render function and see that the component can render a modal.

@zenflow

[hipstersmoothie]

To me it makes sense even though there might be a little overhead. As a react developer i like things being components and having a little thought about being in React.

I agree with you that the swal component should probably not be in the dom all the time. We might want to take the same approach that the Material-UI modals do (they aren't rendered to the dom unless shown. Demo and source here:

https://material-ui-next.com/api/modal/

I think we should move to an even more react-y state and do something like:

     <div>
        <Typography gutterBottom>Click to get the full Modal experience!</Typography>
        <Button onClick={this.handleOpen}>Open Modal</Button>
        <SweetAlert
          open={this.state.open}
          onClose={this.handleClose}
        >
          <div className={classes.paper}>
            <h2>
              Text in a modal
            </h2>
            <p id="simple-modal-description">
              Duis mollis, est non commodo luctus, nisi erat porttitor ligula.
            </p>
          </div>
        </SweetAlert>
      </div>

(opened issue #9)

The one thing that doesn't make sense to when Swal is a component is the then. I haven't played around with trying to chain the Swal Components but I don't see how it would work out in my head.

[zenflow]

To me it makes sense even though there might be a little overhead. As a react developer i like things being components and having a little thought about being in React.

@hipstersmoothie But why does everything need to be a React component? If not using a component results in simpler, more concise code, then isn't that better?

[illtrax]

@zenflow - If you want reusable code, then you want everything to be a component. If it's a small project that doesn't need to scale, then by all means, go for simple.

[alex-shamshurin]

The answer is - yes, this is a component. After all, it will be replaced with sweetalert in react version.