Comments (7)
General Comments
The General comments were addressed in dc65f8f
In densely populated areas, many houses could be within a 100 m x 100 m square. It is also a way to cumulate values for a city/region to identify heat demand hot spots. The quadtree refinement using a variable size of squares demonstrates that even better.
- Definition of MWh: I tried to refine it a little or eliminate the abbreviations in the summary, respectively.
- Definition of HD: This was added to the Statement of Need. I did not add it to the summary to not use abbreviations.
The target audience is included in the Statement of Need: Combining the functionality of well-known geospatial Python libraries, the open-source package PyHeatDemand provides tools for public entities, researchers, or students for processing heat demand input data
. Would that be sufficient?
from pyheatdemand.
Formatting
The formatting issues were addressed in becfecb
All line breaks were removed in the paper and the about section. The Table was fixed.
from pyheatdemand.
Paper Structure
The paper structure was addressed in 6e4b83d
The State of the field was moved to the statement of need section. The outlook was split. The first part went into the summary and the second part was merged with the Resources. This is the only of the three sections that remains now.
from pyheatdemand.
Bibliography
The bibliography issues were addressed in f9e661b
There were indeed some brackets missing.
from pyheatdemand.
References
The references issues were addressed in e9a4c5e
I would refrain from adding a reference to the summary as I see it as an abstract and would not add a reference there either.
Two references were added in the statement of need and an example of where to download heat demand input data for the state of North Rhine-Westphalia was addded to "Processing Heat Demand Input Data" Section
from pyheatdemand.
@nmstreethran with that, I should have addressed your comments and remarks on this issue. Feel free to have a look and thanks again for your great comments!
from pyheatdemand.
The target audience is included in the Statement of Need: Combining the functionality of well-known geospatial Python libraries, the open-source package PyHeatDemand provides tools for public entities, researchers, or students for processing heat demand input data. Would that be sufficient?
Yes, that's sufficient. I'm happy with all the other changes too.
from pyheatdemand.
Related Issues (7)
- [JOSS Review] Installation and documentation HOT 4
- [JOSS Review] Code and examples HOT 4
- [JOSS Review] Issue with `rasterize_gdf_hd` function in notebooks examples HOT 2
- [JOSS Review] Small typo HOT 1
- [JOSS Review] Consider using `black` (or similar) to format the codebase HOT 5
- [JOSS Review ] Use a "numpy.random.Generator" here instead of this legacy function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyheatdemand.