GithubHelp home page GithubHelp logo

Comments (8)

AlexGilleran avatar AlexGilleran commented on May 31, 2024

Have added flow types to the build, which fixes like 2/3 of this but doesn't quite get us all the way :(.

from jsx-control-statements.

gajus avatar gajus commented on May 31, 2024

Without Flowtype support, jsx-control-statements is useless in a project that uses Flowtype, e.g.

<If condition={movie}>
  <div>{movie.name}</div>
</If>

(where movie can null) movie.name will always trigger Flow error.

I am not sure if it possible to solve this in Flowtype.

from jsx-control-statements.

apsavin avatar apsavin commented on May 31, 2024

@AlexGilleran Can we do something to teach flow what If control statement does?

from jsx-control-statements.

AlexGilleran avatar AlexGilleran commented on May 31, 2024

I'm open to suggestions :(.

from jsx-control-statements.

apsavin avatar apsavin commented on May 31, 2024

I opened an issue with a question in flow repo: facebook/flow#4057

from jsx-control-statements.

gajus avatar gajus commented on May 31, 2024

@AlexGilleran @apsavin Has there been any progress on this?

from jsx-control-statements.

AlexGilleran avatar AlexGilleran commented on May 31, 2024

Not in a way that helps us:

Flow understands javascript and jsx semantics. This plugin changes it, so the code is not compatible with flow anymore

Which is fair enough, but also :(.

from jsx-control-statements.

AlexGilleran avatar AlexGilleran commented on May 31, 2024

Although maybe facebook/flow#1515 can save us eventually.

from jsx-control-statements.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.